Add tooling to compare reference and updated output#1
Merged
sylveon merged 4 commits intosylveon:user/sylveon/protected-membersfrom Jul 11, 2023
Merged
Conversation
Owner
|
Looks great! I'd suggest adding .ixx to the prepare_versionless_diffs.cmd tool's list of files, as otherwise it misses modules (the current winrt.ixx + future changes which might add more). Also I hit a footgun with this: I ran |
Owner
|
Also, I don't think anybody would mind a PowerShell script instead ;) |
added 3 commits
July 11, 2023 13:19
Turns out the cppwinrt project depends on prebuild already
Author
|
Alrighty, done. Powershell and doc update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's some scripts to help validate the comparison. I wish
cmd.exehad a better built-in text manipulation tool. Powershell makes this easy; routing through "copy + findstr /v" is very slow.The comparison looks pretty reasonable on the Big Windows metadata.