Add webgl2 IDL spec and generated code#18
Merged
MaxDesiatov merged 22 commits intomainfrom May 3, 2022
Merged
Conversation
This is a requirement for `webgl2`, which I'm going to add in a future PR.
# Conflicts: # Sources/DOMKit/Generated.swift # parse-idl/parse-all.js
j-f1
approved these changes
May 3, 2022
Member
j-f1
left a comment
There was a problem hiding this comment.
Getting to see WebAPIKit code actually being run is awesome! And after my brush with OpenGL in C++ last fall I think the argument labels alone are a MASSIVE improvement haha. Thanks for pushing this through!
Comment on lines
10
to
11
| //extension WebGL2RenderingContext: Any_RenderingContext {} | ||
| //extension WebGLRenderingContext: Any_RenderingContext {} | ||
| // extension WebGL2RenderingContext: Any_RenderingContext {} | ||
| // extension WebGLRenderingContext: Any_RenderingContext {} |
Member
Author
|
Thanks! I'm thinking of integrating Euclid with WebGL 2 via WebAPIKit. Thankfully, Euclid already compiles and passes all tests almost without issues. It would take time to make something comparable to three.js, but could be a start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added WebGL 2 example code to
DOMKitDemoported from https://webgl2fundamentals.org/webgl/lessons/webgl-fundamentals.html, which is under MIT/BSD3-like license (added inline to the file), looks like this in action after you press the button. Just a pink triangle, but it finally works!