Merged
Conversation
Owner
|
Looks OK, but I am seeing this error:
|
Contributor
Author
|
I don't see any issue on my side, or on GitHub. Are you on the master branch? |
Owner
|
Now it is working. Approved, starting 3 day comment window. |
stleary
added a commit
to stleary/JSON-Java-unit-test
that referenced
this pull request
Dec 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
See PR #447
Adds a check for EOF in
Tokener.nextValue()before callingback().Risks
Low. Should not affect callers
Changes to the API?
No.
Will this require a new release?
No.
Should the documentation be updated?
No.
Does it break the unit tests?
No. New unit tests added, see stleary/JSON-Java-unit-test#91
Was any code refactored in this commit?
No
Review status
APPROVED