Skip to content

Fix test_exppp_supertype_andor CMake version inconsistency#3

Merged
starseeker merged 2 commits intobuildfixesfrom
copilot/debug-test-exppp-supertype-andor
Dec 5, 2025
Merged

Fix test_exppp_supertype_andor CMake version inconsistency#3
starseeker merged 2 commits intobuildfixesfrom
copilot/debug-test-exppp-supertype-andor

Conversation

Copy link

Copilot AI commented Dec 5, 2025

The test_exppp_supertype_andor test was failing on OSX and Windows due to CMake 2.8 usage while all other exppp tests require 3.12+. CMake 2.8 (2009-2011) has platform-specific behavior in string operations that can cause string(FIND ...) to behave inconsistently.

Changes

  • Updated cmake_minimum_required(VERSION 2.8) to VERSION 3.12 in exppp_supertype_andor.cmake

Context

The test verifies that the EXPRESS pretty printer outputs three closing parentheses when formatting ANDOR expressions within SUPERTYPE ONEOF clauses:

ABSTRACT SUPERTYPE OF (ONEOF (
  VERTEX,
  (LOOP ANDOR PATH)  -- Requires parens: ( ) ) )
))

The test searches for "path ) ) )" in the output. CMake version inconsistency was the only environmental difference between this test and passing tests.

Original prompt

test_exppp_supertype_andor seems to be failing, at least on OSX and Windows - can you determine why?


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: starseeker <238416+starseeker@users.noreply.github.com>
Copilot AI changed the title [WIP] Debug test_exppp_supertype_andor failures on OSX and Windows Fix test_exppp_supertype_andor CMake version inconsistency Dec 5, 2025
Copilot AI requested a review from starseeker December 5, 2025 21:37
@starseeker starseeker marked this pull request as ready for review December 5, 2025 21:53
@starseeker starseeker merged commit c2dc4f1 into buildfixes Dec 5, 2025
@starseeker starseeker deleted the copilot/debug-test-exppp-supertype-andor branch December 5, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants