Fix test_exppp_supertype_andor CMake version inconsistency#3
Merged
starseeker merged 2 commits intobuildfixesfrom Dec 5, 2025
Merged
Conversation
Co-authored-by: starseeker <238416+starseeker@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Debug test_exppp_supertype_andor failures on OSX and Windows
Fix test_exppp_supertype_andor CMake version inconsistency
Dec 5, 2025
starseeker
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_exppp_supertype_andortest was failing on OSX and Windows due to CMake 2.8 usage while all other exppp tests require 3.12+. CMake 2.8 (2009-2011) has platform-specific behavior in string operations that can causestring(FIND ...)to behave inconsistently.Changes
cmake_minimum_required(VERSION 2.8)toVERSION 3.12inexppp_supertype_andor.cmakeContext
The test verifies that the EXPRESS pretty printer outputs three closing parentheses when formatting ANDOR expressions within SUPERTYPE ONEOF clauses:
The test searches for
"path ) ) )"in the output. CMake version inconsistency was the only environmental difference between this test and passing tests.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.