Merged
Conversation
Contributor
strvmarv
commented
Oct 10, 2017
- Internal logging improvements
- Consistency check compile constants
* Internal logging improvements * Consistency check compile constants
eric-martin
reviewed
Oct 10, 2017
|
|
||
|
|
||
|
|
||
| public static void Log(string message, bool logAnyways = false) |
Contributor
There was a problem hiding this comment.
Have this call into the Log method below and handle the null ex case there. Duplicated code.
eric-martin
approved these changes
Oct 10, 2017
Contributor
eric-martin
left a comment
There was a problem hiding this comment.
Just one comment below.
* Duplicate code
* Increment versions for nuget deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.