Add array of accepted synonym packages for sheetify #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Ping @emilbayes @goto-bus-stop perhaps you would have thoughts on this. |
emilbayes
reviewed
Jun 17, 2019
emilbayes
reviewed
Jun 17, 2019
Contributor
Author
|
@emilbayes ok updated. wdyt? |
Array.prototype.includes is not defined in older nodes
Contributor
Author
|
Looks like includes would be a major version bump. Fine with me. |
goto-bus-stop
approved these changes
Jun 24, 2019
Contributor
Author
|
Tests pass up till node 6, so the major version bump should note that. |
Contributor
Author
|
I'm going to release an 8.0.0-beta0 today and ensure this works properly in the wild. After that, I will release the 8.0.0 with a CHANGELOG/release page. |
Contributor
Author
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking to export sheetify from
huiin order to enforce the same version of the tool across a codebase built on that component library. This PR attempts to add an array similar to what is found in hyperhtml which would enable the ability to use package synonyms.