packages/stack-shared/src/helpers/emails.ts (1)

45-46: Duplicate imports inside LightEmailTheme string cause syntax error

There are two import lines for @react-email/components inside the template string. This will break bundling.

Apply this dedupe:

-export const LightEmailTheme = `import { Html, Head, Tailwind, Body, Container, Link } from '@react-email/components';
-import { Html, Head, Tailwind, Body, Container, Link, Img } from '@react-email/components';
+export const LightEmailTheme = `import { Html, Head, Tailwind, Body, Container, Link, Img } from '@react-email/components';

apps/backend/src/lib/email-rendering.tsx (1)

95-101: Fix: spreading possibly undefined themeProps throws at runtime; also set correct merge precedence

If options.themeProps is undefined, JSON.stringify(options.themeProps) becomes undefined and {...undefined} throws. Also, PreviewProps should provide defaults that call-site props can override, not the other way around.

Apply:

-        const themeProps = {
-          ...${JSON.stringify(options.themeProps)},
-          ...${previewMode ? "EmailTheme.PreviewProps" : "{}"},
-        }
+        const themeProps = {
+          ...${previewMode ? "EmailTheme.PreviewProps" : "{}"},
+          ...${JSON.stringify(options.themeProps || {})},
+        }

This unblocks first-pass renders (which don’t pass themeProps) in send-email and prevents PreviewProps from clobbering explicit props.

packages/stack-shared/src/helpers/emails.ts (5)

47-47: Prefer type-only import for ThemeProps to avoid runtime import

Using a value import for a type may keep an unnecessary import after transpilation depending on settings.

-import { ThemeProps } from "@stackframe/emails"
+import type { ThemeProps } from "@stackframe/emails"

---

56-63: Add text fallback and better alt text for accessibility

If neither logo is set, nothing renders; also alt text should be descriptive.

-            {fullLogoUrl ? 
-              <Img src={fullLogoUrl} alt="Full Logo" className="h-16" /> :
-              logoUrl ? 
-                <div className="flex gap-2 items-center">
-                  <Img src={logoUrl} alt="Logo" className="h-8" />
-                  <h2>{projectDisplayName}</h2>
-                </div>
-                : null}
+            {fullLogoUrl ? (
+              <Img src={fullLogoUrl} alt={(projectDisplayName ? projectDisplayName + " " : "") + "full logo"} className="h-16" />
+            ) : logoUrl ? (
+              <div className="flex gap-2 items-center">
+                <Img src={logoUrl} alt={(projectDisplayName ? projectDisplayName + " " : "") + "logo"} className="h-8" />
+                <h2>{projectDisplayName}</h2>
+              </div>
+            ) : (
+              projectDisplayName ? <h2>{projectDisplayName}</h2> : null
+            )}

---

79-80: Consider enriching PreviewProps to showcase branding in preview

Optional: add sample projectDisplayName/logoUrl to improve preview experience in the editor.

 EmailTheme.PreviewProps = {
-  unsubscribeLink: "https://example.com",
+  unsubscribeLink: "https://example.com",
+  projectDisplayName: "Acme Inc.",
+  // logoUrl: "https://example.com/logo.png",
+  // fullLogoUrl: "https://example.com/full-logo.png",
 } satisfies Partial<ThemeProps>

---

84-85: Prefer type-only import for ThemeProps in Dark theme

Same rationale as Light theme.

-const DarkEmailTheme = `import { Html, Head, Tailwind, Body, Container, Link, Img } from '@react-email/components';
-import { ThemeProps } from "@stackframe/emails"
+const DarkEmailTheme = `import { Html, Head, Tailwind, Body, Container, Link, Img } from '@react-email/components';
+import type { ThemeProps } from "@stackframe/emails"

---

94-101: Dark theme: add text fallback and descriptive alt text

Mirror Light theme’s accessibility improvements.

-            {fullLogoUrl ? 
-              <Img src={fullLogoUrl} alt="Full Logo" className="h-16" /> :
-              logoUrl ? 
-                <div className="flex gap-2 items-center">
-                  <Img src={logoUrl} alt="Logo" className="h-8" />
-                  <h2 className="text-white">{projectDisplayName}</h2>
-                </div>
-                : null}
+            {fullLogoUrl ? (
+              <Img src={fullLogoUrl} alt={(projectDisplayName ? projectDisplayName + " " : "") + "full logo"} className="h-16" />
+            ) : logoUrl ? (
+              <div className="flex gap-2 items-center">
+                <Img src={logoUrl} alt={(projectDisplayName ? projectDisplayName + " " : "") + "logo"} className="h-8" />
+                <h2 className="text-white">{projectDisplayName}</h2>
+              </div>
+            ) : (
+              projectDisplayName ? <h2 className="text-white">{projectDisplayName}</h2> : null
+            )}

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/backend/src/lib/email-rendering.tsx (1)

95-98: Guard spread of PreviewProps to prevent runtime TypeError in preview mode.

Spreading EmailTheme.PreviewProps throws if it's undefined. Use nullish coalescing.

-        const themeProps = {
-          ...${JSON.stringify(options.themeProps || {})},
-          ...${previewMode ? "EmailTheme.PreviewProps" : "{}"},
-        }
+        const themeProps = {
+          ...${JSON.stringify(options.themeProps || {})},
+          ...${previewMode ? "(EmailTheme.PreviewProps ?? {})" : "{}"},
+        }

apps/e2e/tests/backend/endpoints/api/v1/integrations/custom/projects/provision.test.ts (1)

80-86: Consistent field rename in provisioning snapshot.

Changed to logo_full_url as expected. Consider adding coverage for dark-mode logo fields when those are exposed by this endpoint.

packages/stack-shared/src/helpers/emails.ts (4)

45-50: Remove redundant ThemeProps import outside the template string.

There’s an extra import { ThemeProps } from "@stackframe/emails" outside the TSX string that isn’t used.

Apply:

 export const LightEmailTheme = `import { Html, Head, Tailwind, Body, Container, Link, Img } from '@react-email/components';
 import { ThemeProps } from "@stackframe/emails"
-import { ThemeProps } from "@stackframe/emails"

---

56-64: Add header fallback when no logos are provided (show project name).

Currently nothing renders if both logoFullUrl and logoUrl are absent. Show projectDisplayName alone to keep consistent branding.

Apply:

-            {logoFullUrl ? 
-              <Img src={logoFullUrl} alt="Full Logo" className="h-16" /> :
-              logoUrl ? 
-                <div className="flex gap-2 items-center">
-                  <Img src={logoUrl} alt="Logo" className="h-8" />
-                  <h2>{projectDisplayName}</h2>
-                </div>
-                : null}
+            {logoFullUrl ? (
+              <Img
+                src={logoFullUrl}
+                alt={projectDisplayName ? `${projectDisplayName} full logo` : "Project full logo"}
+                className="h-16"
+                height={64}
+              />
+            ) : logoUrl ? (
+              <div className="flex gap-2 items-center">
+                <Img
+                  src={logoUrl}
+                  alt={projectDisplayName ? `${projectDisplayName} logo` : "Project logo"}
+                  className="h-8"
+                  height={32}
+                />
+                {projectDisplayName ? <h2>{projectDisplayName}</h2> : null}
+              </div>
+            ) : (
+              projectDisplayName ? <h2>{projectDisplayName}</h2> : null
+            )}

---

94-101: Mirror the no-logo fallback in Dark theme.

Same rationale as Light theme; also keep contrast for heading.

Apply:

-            {logoFullDarkModeUrl ? 
-              <Img src={logoFullDarkModeUrl} alt="Full Logo" className="h-16" /> :
-              logoDarkModeUrl ? 
-                <div className="flex gap-2 items-center">
-                  <Img src={logoDarkModeUrl} alt="Logo" className="h-8" />
-                  <h2 className="text-white">{projectDisplayName}</h2>
-                </div>
-                : null}
+            {logoFullDarkModeUrl ? (
+              <Img
+                src={logoFullDarkModeUrl}
+                alt={projectDisplayName ? `${projectDisplayName} full logo` : "Project full logo"}
+                className="h-16"
+                height={64}
+              />
+            ) : logoDarkModeUrl ? (
+              <div className="flex gap-2 items-center">
+                <Img
+                  src={logoDarkModeUrl}
+                  alt={projectDisplayName ? `${projectDisplayName} logo` : "Project logo"}
+                  className="h-8"
+                  height={32}
+                />
+                {projectDisplayName ? <h2 className="text-white">{projectDisplayName}</h2> : null}
+              </div>
+            ) : (
+              projectDisplayName ? <h2 className="text-white">{projectDisplayName}</h2> : null
+            )}

---

106-108: Minor a11y: clarify unsubscribe link text.

“Click here to unsubscribe” is fine; consider a clearer label for screen readers.

Apply:

-              <Link href={unsubscribeLink} className="text-gray-300">Click here{" "}</Link>
-              to unsubscribe from these emails
+              <Link href={unsubscribeLink} className="text-gray-300" aria-label="Unsubscribe from these emails">
+                Unsubscribe
+              </Link>

apps/backend/src/app/api/latest/emails/send-email/route.tsx (1)

159-166: ThemeProps wiring LGTM

Passing branding + unsubscribe via themeProps is consistent with the renderer change.

For consistency, consider passing the same themeProps (minus unsubscribeLink) in the first render pass used to detect the notification category to avoid divergence if templates start referencing branding in that branch.

packages/template/src/lib/stack-app/projects/index.ts (1)

58-111: Avoid sending an all-undefined config payload

adminProjectUpdateOptionsToCrud always includes a config object, mostly with undefined values when options.config is not provided. Prefer omitting config entirely to reduce downstream branching and accidental overrides.

 export function adminProjectUpdateOptionsToCrud(options: AdminProjectUpdateOptions): ProjectsCrud["Admin"]["Update"] {
-  return {
-    display_name: options.displayName,
-    description: options.description,
-    is_production_mode: options.isProductionMode,
-    logo_url: options.logoUrl,
-    logo_full_url: options.logoFullUrl,
-    logo_dark_mode_url: options.logoDarkModeUrl,
-    logo_full_dark_mode_url: options.logoFullDarkModeUrl,
-    config: {
+  const config = options.config ? {
       domains: options.config?.domains?.map((d) => ({
         domain: d.domain,
         handler_path: d.handlerPath
       })),
       oauth_providers: options.config?.oauthProviders?.map((p) => ({
         id: p.id as any,
         type: p.type,
         ...(p.type === 'standard' && {
           client_id: p.clientId,
           client_secret: p.clientSecret,
           facebook_config_id: p.facebookConfigId,
           microsoft_tenant_id: p.microsoftTenantId,
         }),
       })),
       email_config: options.config?.emailConfig && (
         options.config.emailConfig.type === 'shared' ? {
           type: 'shared',
         } : {
           type: 'standard',
           host: options.config.emailConfig.host,
           port: options.config.emailConfig.port,
           username: options.config.emailConfig.username,
           password: options.config.emailConfig.password,
           sender_name: options.config.emailConfig.senderName,
           sender_email: options.config.emailConfig.senderEmail,
         }
       ),
       email_theme: options.config?.emailTheme,
       sign_up_enabled: options.config?.signUpEnabled,
       credential_enabled: options.config?.credentialEnabled,
       magic_link_enabled: options.config?.magicLinkEnabled,
       passkey_enabled: options.config?.passkeyEnabled,
       allow_localhost: options.config?.allowLocalhost,
       create_team_on_sign_up: options.config?.createTeamOnSignUp,
       client_team_creation_enabled: options.config?.clientTeamCreationEnabled,
       client_user_deletion_enabled: options.config?.clientUserDeletionEnabled,
       team_creator_default_permissions: options.config?.teamCreatorDefaultPermissions,
       team_member_default_permissions: options.config?.teamMemberDefaultPermissions,
       user_default_permissions: options.config?.userDefaultPermissions,
       oauth_account_merge_strategy: options.config?.oauthAccountMergeStrategy,
       allow_user_api_keys: options.config?.allowUserApiKeys,
       allow_team_api_keys: options.config?.allowTeamApiKeys,
-    },
-  };
+    }
+  } : undefined;
+
+  return {
+    display_name: options.displayName,
+    description: options.description,
+    is_production_mode: options.isProductionMode,
+    logo_url: options.logoUrl,
+    logo_full_url: options.logoFullUrl,
+    logo_dark_mode_url: options.logoDarkModeUrl,
+    logo_full_dark_mode_url: options.logoFullDarkModeUrl,
+    ...(config ? { config } : {}),
+  };
 }

apps/backend/src/lib/projects.tsx (2)

93-100: Upload logo variants in parallel and improve typing

Parallelize uploads and use a precise type for the four keys (or a Map, per guidelines) instead of Record<string,...>.

-  const logoFields = ['logo_url', 'full_logo_url', 'logo_dark_mode_url', 'logo_full_dark_mode_url'] as const;
-  const logoUrls: Record<string, string | null | undefined> = {};
-
-  for (const field of logoFields) {
-    if (options.data[field] !== undefined) {
-      logoUrls[field] = await uploadAndGetUrl(options.data[field], "project-logos");
-    }
-  }
+  const logoFields = ['logo_url', 'full_logo_url', 'logo_dark_mode_url', 'logo_full_dark_mode_url'] as const;
+  type LogoField = typeof logoFields[number];
+  const entries = await Promise.all(
+    logoFields.map<Promise<[LogoField, string | null | undefined]>>(async (field) => {
+      return [field, options.data[field] !== undefined ? await uploadAndGetUrl(options.data[field], "project-logos") : undefined];
+    })
+  );
+  const logoUrls = Object.fromEntries(entries) as Partial<Record<LogoField, string | null | undefined>>;

---

114-118: Map access to typed keys

Switching to the typed object (or a Map) avoids stringly-typed key access.

-          logoUrl: logoUrls.logo_url,
-          logoFullUrl: logoUrls.full_logo_url,
-          logoDarkModeUrl: logoUrls.logo_dark_mode_url,
-          logoFullDarkModeUrl: logoUrls.logo_full_dark_mode_url,
+          logoUrl: logoUrls.logo_url,
+          logoFullUrl: logoUrls.full_logo_url,
+          logoDarkModeUrl: logoUrls.logo_dark_mode_url,
+          logoFullDarkModeUrl: logoUrls.logo_full_dark_mode_url,

(kept identical keys; relies on the typed change above)

Also applies to: 148-152

apps/backend/src/lib/email-rendering.tsx (1)

100-102: Avoid passing 'children' via spread; rely on explicit children composition.

If PreviewProps.children exists, it’s redundantly passed in props and as explicit children. Strip it in the merge to reduce ambiguity.

-        const themeProps = {
-          ...${JSON.stringify(options.themeProps || {})},
-          ...${previewMode ? "(EmailTheme.PreviewProps ?? {})" : "{}"},
-        }
+        const __previewProps = ${previewMode ? "(EmailTheme.PreviewProps ?? {})" : "{}"};
+        const { children: __ignoredChildren, ...__previewPropsSansChildren } = __previewProps;
+        const themeProps = {
+          ...${JSON.stringify(options.themeProps || {})},
+          ...__previewPropsSansChildren,
+        }

apps/e2e/tests/backend/endpoints/api/v1/team-permissions.test.ts (1)

230-267: Optionally assert the legacy field is absent to guard against regressions.

Keeps the contract strict while retaining the inline snapshot.

   expect(response2).toMatchInlineSnapshot(`
     NiceResponse {
       "status": 200,
       "body": {
         "config": {
@@
         "owner_team_id": "<stripped UUID>",
       },
       "headers": Headers { <some fields may have been hidden> },
     }
   `);
+  // Ensure deprecated field isn't accidentally returned
+  expect(response2.body).not.toHaveProperty("full_logo_url");

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/backend/src/lib/projects.tsx (1)

65-66: Fix created_at_millis: avoid coercing Date to string

Using row.createdAt + "Z" can yield Invalid Date. Use the Date directly or parse only when string.

Apply this diff:

-        created_at_millis: new Date(row.createdAt + "Z").getTime(),
+        created_at_millis: row.createdAt instanceof Date
+          ? row.createdAt.getTime()
+          : new Date(row.createdAt).getTime(),

apps/backend/src/lib/projects.tsx (3)

93-101: Use Map over Record and parallelize uploads

Follows repo guideline (prefer ES6 Map). Also removes sequential awaits.

Apply this diff:

   const logoFields = ['logo_url', 'logo_full_url', 'logo_dark_mode_url', 'logo_full_dark_mode_url'] as const;
-  const logoUrls: Record<string, string | null | undefined> = {};
-
-  for (const field of logoFields) {
-    if (options.data[field] !== undefined) {
-      logoUrls[field] = await uploadAndGetUrl(options.data[field], "project-logos");
-    }
-  }
+  const logoUrls = new Map<typeof logoFields[number], string | null>();
+  await Promise.all(
+    logoFields.map(async (field) => {
+      const input = options.data[field];
+      if (input !== undefined) {
+        const url = await uploadAndGetUrl(input, "project-logos");
+        logoUrls.set(field, url ?? null);
+      }
+    })
+  );

(Optional) To avoid passing undefineds to Prisma, build a filtered object:

const logosData = filterUndefined({
  logoUrl: logoUrls.get('logo_url') ?? undefined,
  logoFullUrl: logoUrls.get('logo_full_url') ?? undefined,
  logoDarkModeUrl: logoUrls.get('logo_dark_mode_url') ?? undefined,
  logoFullDarkModeUrl: logoUrls.get('logo_full_dark_mode_url') ?? undefined,
});

---

114-118: Read from Map and avoid undefined writes

Use Map#get; consider wrapping data with filterUndefined to skip untouched fields.

Apply this diff:

-          logoUrl: logoUrls['logo_url'],
-          logoFullUrl: logoUrls['logo_full_url'],
-          logoDarkModeUrl: logoUrls['logo_dark_mode_url'],
-          logoFullDarkModeUrl: logoUrls['logo_full_dark_mode_url'],
+          logoUrl: logoUrls.get('logo_url'),
+          logoFullUrl: logoUrls.get('logo_full_url'),
+          logoDarkModeUrl: logoUrls.get('logo_dark_mode_url'),
+          logoFullDarkModeUrl: logoUrls.get('logo_full_dark_mode_url'),

(Optional) Wrap the whole data object:

data: filterUndefined({
  // existing fields...
  logoUrl: logoUrls.get('logo_url'),
  logoFullUrl: logoUrls.get('logo_full_url'),
  logoDarkModeUrl: logoUrls.get('logo_dark_mode_url'),
  logoFullDarkModeUrl: logoUrls.get('logo_full_dark_mode_url'),
})

---

148-152: Same Map usage for update path

Mirror the create-path change; also consider filterUndefined to prevent accidental field nulling.

Apply this diff:

-          logoUrl: logoUrls['logo_url'],
-          logoFullUrl: logoUrls['logo_full_url'],
-          logoDarkModeUrl: logoUrls['logo_dark_mode_url'],
-          logoFullDarkModeUrl: logoUrls['logo_full_dark_mode_url'],
+          logoUrl: logoUrls.get('logo_url'),
+          logoFullUrl: logoUrls.get('logo_full_url'),
+          logoDarkModeUrl: logoUrls.get('logo_dark_mode_url'),
+          logoFullDarkModeUrl: logoUrls.get('logo_full_dark_mode_url'),

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

packages/stack-shared/src/helpers/emails.ts (1)

45-46: Duplicate import warning from earlier bots is resolved — keep as-is.

Only one @react-email/components import remains; the second import is for ThemeProps and is required.

packages/stack-shared/src/helpers/emails.ts (4)

67-69: Use descriptive unsubscribe link text (accessibility + clarity).

“Click here” is non-descriptive. Prefer “Unsubscribe”.

-              <Link href={unsubscribeLink}>Click here{" "}</Link>
-              to unsubscribe from these emails
+              <Link href={unsubscribeLink}>Unsubscribe</Link>{" "}
+              from these emails

-              <Link href={unsubscribeLink} className="text-gray-300">Click here{" "}</Link>
-              to unsubscribe from these emails
+              <Link href={unsubscribeLink} className="text-gray-300">Unsubscribe</Link>{" "}
+              from these emails

Also applies to: 119-121

---

83-83: Export DarkEmailTheme for parity and reuse.

Keeps API symmetrical with LightEmailTheme.

-const DarkEmailTheme = `import { Html, Head, Tailwind, Body, Container, Link, Img } from '@react-email/components';
+export const DarkEmailTheme = `import { Html, Head, Tailwind, Body, Container, Link, Img } from '@react-email/components';

---

95-97: Flatten nested ternaries and make FullLogo’s alt descriptive.

Improves readability and brand-specific alt text.

-function FullLogo(props: { logoFullUrl: string }) {
-  return <Img src={props.logoFullUrl} alt="Full Logo" className="h-16" />;
+function FullLogo(props: { logoFullUrl: string; projectDisplayName?: string }) {
+  return (
+    <Img
+      src={props.logoFullUrl}
+      alt={props.projectDisplayName ? `${props.projectDisplayName} full logo` : "Full logo"}
+      className="h-16"
+    />
+  );
 }

-            {logoFullDarkModeUrl ?
-              <FullLogo logoFullUrl={logoFullDarkModeUrl} /> :
-              logoDarkModeUrl ?
-                <Logo logoUrl={logoDarkModeUrl} projectDisplayName={projectDisplayName} /> :
-                  logoFullUrl ?
-                    <FullLogo logoFullUrl={logoFullUrl} /> :
-                      logoUrl ?
-                        <Logo logoUrl={logoUrl} projectDisplayName={projectDisplayName} /> :
-                          null}
+            {(() => {
+              if (logoFullDarkModeUrl) return <FullLogo logoFullUrl={logoFullDarkModeUrl} projectDisplayName={projectDisplayName} />;
+              if (logoDarkModeUrl) return <Logo logoUrl={logoDarkModeUrl} projectDisplayName={projectDisplayName} />;
+              if (logoFullUrl) return <FullLogo logoFullUrl={logoFullUrl} projectDisplayName={projectDisplayName} />;
+              if (logoUrl) return <Logo logoUrl={logoUrl} projectDisplayName={projectDisplayName} />;
+              return null;
+            })()}

Also applies to: 106-114

---

78-79: Enhance PreviewProps to showcase branding in the preview.

Helps designers see header logos without wiring backend.

 EmailTheme.PreviewProps = {
-  unsubscribeLink: "https://example.com",
+  unsubscribeLink: "https://example.com",
+  projectDisplayName: "Acme Inc.",
+  logoUrl: "https://example.com/logo.png",
+  logoFullUrl: "https://example.com/logo-full.png",
 } satisfies Partial<ThemeProps>

 EmailTheme.PreviewProps = {
-  unsubscribeLink: "https://example.com",
+  unsubscribeLink: "https://example.com",
+  projectDisplayName: "Acme Inc.",
+  logoDarkModeUrl: "https://example.com/logo-dark.png",
+  logoFullDarkModeUrl: "https://example.com/logo-full-dark.png",
 } satisfies Partial<ThemeProps>

Also applies to: 130-131

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/backend/src/lib/projects.tsx (1)

65-65: Address the Date conversion issue flagged in previous review.

The created_at_millis conversion issue remains unresolved. As noted in the previous review, appending "Z" to a Date object coerces it to a string and can yield Invalid Date.

apps/backend/src/lib/email-rendering.tsx (1)

97-100: Address the PreviewProps guard issue flagged in previous review.

The unguarded spread of EmailTheme.PreviewProps can cause a runtime TypeError if PreviewProps is undefined. The previous review recommended using (EmailTheme.PreviewProps ?? {}) to prevent this.

apps/dashboard/src/components/vibe-coding/code-editor.tsx (3)

33-51: Reconsider disabling strictFunctionTypes in the editor TS config

Turning off strictFunctionTypes globally weakens function type checking (especially for callbacks) in the code editor, which can hide real mistakes users make in templates.

If this was added only to work around specific library type incompatibilities, consider a narrower fix instead (e.g., tweaking the affected declaration(s) only) so the rest of the editor can keep full strict behavior. At minimum, a short comment here explaining the rationale would help future maintainers understand why this strictness flag is relaxed.

---

55-67: Transform hook for remote d.ts is useful; minor robustness/clarity tweaks

The transform hook on fetchAndAddTypeDefinition plus transformTailwindTypeFile is a nice, targeted way to patch the @react-email/tailwind types without forking them; the control flow and usage look sound.

A couple of small suggestions:

• Consider adding a brief comment above transformTailwindTypeFile explaining which upstream signature you’re patching and why (e.g., mismatch with JSX.Element | null), so future updates to @react-email/tailwind know what to check.
• If @react-email/tailwind ever adds multiple overloaded signatures matching this pattern, the single replace may miss some. If you expect more than one, making the regex global (/.../g) would keep the patch scalable.

These are non-blocking, but would make this “stringly typed” patch easier to maintain.

Also applies to: 124-130, 134-139

---

83-107: Confirm ThemeProps['projectLogos'] shape and optionality matches the real API

The projectLogos object and ProjectLogo component typing generally look aligned with the PR’s logo fields (four optional URLs on a logos object).

Two details to double‑check against @stackframe/emails’ actual ThemeProps:

• projectLogos is required on ThemeProps (the properties inside are optional). If the real theme props allow projectLogos to be absent entirely, this stub should likely be projectLogos?: { ... } to avoid mismatch and confusing editor errors.
• ProjectLogo’s data prop is typed as ThemeProps['projectLogos'], which is therefore non-nullable. If ProjectLogo is intended to handle the “no logos configured” case (e.g., undefined or null), it might be better typed as ThemeProps['projectLogos'] | undefined (or similar).

Adjust only if they diverge from the actual runtime typings; otherwise this looks good.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/backend/src/lib/email-rendering.tsx (1)

97-100: Guard the spread of EmailTheme.PreviewProps to prevent runtime TypeError.

When previewMode is true and EmailTheme.PreviewProps is undefined, the generated code will attempt to spread undefined, causing a runtime error.

Apply this diff to add nullish coalescing:

         const themeProps = {
           ...${JSON.stringify(options.themeProps || {})},
-          ...${previewMode ? "EmailTheme.PreviewProps" : "{}"},
+          ...${previewMode ? "(EmailTheme.PreviewProps ?? {})" : "{}"},
         }

apps/backend/src/lib/email-rendering.tsx (1)

335-365: Consider adding validation for required logo URLs.

The ProjectLogo component returns components that depend on specific URL props (logoUrl, logoFullUrl, etc.) but doesn't validate these URLs exist before passing them. While the Img component may handle undefined src gracefully, explicit checks would make the logic clearer.

Example validation before returning Logo:

if (mode === "dark" && logoDarkModeUrl) {
  return React.createElement(Logo, {
    logoUrl: logoDarkModeUrl,
    projectDisplayName,
  });
}

Could be:

if (mode === "dark" && logoDarkModeUrl && projectDisplayName) {
  return React.createElement(Logo, {
    logoUrl: logoDarkModeUrl,
    projectDisplayName,
  });
}

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/backend/src/lib/email-rendering.tsx (1)

97-100: Guard against undefined EmailTheme.PreviewProps to prevent runtime error.

The spread ...EmailTheme.PreviewProps on line 99 will throw a TypeError if PreviewProps is undefined. Although this was marked as addressed in a previous review, the code still lacks the guard.

Apply this diff to safely handle undefined PreviewProps:

         const themeProps = {
           ...${JSON.stringify(options.themeProps || {})},
-          ...${previewMode ? "EmailTheme.PreviewProps" : "{}"},
+          ...${previewMode ? "(EmailTheme.PreviewProps ?? {})" : "{}"},
         }

apps/backend/src/lib/email-rendering.tsx (2)

197-200: Simplify themeProps construction by removing unnecessary spread.

Line 198 spreads an object literal containing a single key, which can be written more directly.

Apply this diff for cleaner code:

           const themeProps = {
-            ...{ projectLogos: input.themeProps?.projectLogos ?? {} },
+            projectLogos: input.themeProps?.projectLogos ?? {},
             unsubscribeLink: input.unsubscribeLink,
           }

---

311-321: Remove unused gap-2 className from Logo component.

The Logo component applies gap-2 to a flex container, but it only has a single child image. This className has no effect and may be leftover from a previous version that rendered text alongside the logo.

Apply this diff to clean up the unused style:

   export function Logo(props) {
     return React.createElement(
       "div",
-      { className: "flex gap-2 items-center" },
+      { className: "flex items-center" },
       React.createElement(Img, {
         logoUrl: props.logoUrl,
         alt: "Logo",
         className: "h-8",
       }),
     );
   }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro