Skip to content

Don't inline fields of embedded messages, keep them as separated messages #92

Description

@erizocosmico

Right now, if we do something like the following:

type Model struct {
  ID int64
}

type User struct {
  Model
  Name string
}

The result of the proto generated by proteus is:

message User {
  int64 id = 1;
  string name = 2;
}

Which works fine right now, but we should maybe change it because as a result, Model is not generated and does not get its ProtoMessage and all the mumbo jumbo it should have generated for it, which can be a mess for reflection-based marshal/unmarshal if we finally make it work with that.

Right now it works, but we should evaluate if this is worth fixing/changing or not in the long run.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions