Skip to content

feat: tailwind v4#324

Open
dmitriy-kostianetskiy wants to merge 20 commits intomainfrom
feat/tailwind-v4
Open

feat: tailwind v4#324
dmitriy-kostianetskiy wants to merge 20 commits intomainfrom
feat/tailwind-v4

Conversation

@dmitriy-kostianetskiy
Copy link
Collaborator

@dmitriy-kostianetskiy dmitriy-kostianetskiy commented Jan 27, 2026

  • Upgrade tailwind up to v4
  • Set up css-based tailwind configuration
  • Replace PostCSS + Autoprefixer with tailwind vite plugin
  • Replace deprecated tailwind classes
  • Test sqlrooms-cli app locally (@ilyabo I do need some help with python backend)
  • Update StackBlitz examples
  • Update migration guide and readme
  • Update husky pre-commit hook to be more volta-friendly
  • Exclude tailwind css files from knip (they are generation tons of import errors which make no sense)

Looks like it works :)

image image image

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request upgrades the project from Tailwind CSS v3 to v4, representing a significant modernization of the styling infrastructure. The upgrade adopts Tailwind v4's new CSS-first configuration approach, replacing JavaScript-based configuration with CSS @import and @source directives.

Changes:

  • Replaced tailwind.config.js/tailwind.config.ts with CSS-based configuration using @source directives in all projects
  • Removed the sqlroomsTailwindPreset TypeScript function in favor of a CSS preset file (packages/ui/tailwind-preset.css)
  • Migrated from PostCSS + Autoprefixer to the new @tailwindcss/vite plugin for Vite projects (Next.js projects use @tailwindcss/postcss)
  • Moved CSS custom properties out of @layer base to root level as required by Tailwind v4
  • Updated documentation with migration guide and new installation instructions

Reviewed changes

Copilot reviewed 120 out of 121 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/ui/tailwind-preset.css New CSS-based preset replacing the TypeScript configuration
packages/ui/src/tailwind-preset.ts Removed - no longer needed with CSS-first approach
packages/ui/src/index.ts Removed export of deprecated sqlroomsTailwindPreset
packages/ui/package.json Updated peer dependency from Tailwind v3 to v4, removed autoprefixer
packages/ui/components.json Updated config path to point to CSS file
knip.json Added CSS file ignoring and formatted arrays
examples/*/vite.config.ts Added @tailwindcss/vite plugin to all Vite projects
examples/*/tailwind.config.ts Removed - replaced by CSS configuration
examples/*/src/index.css Added @source directives and removed @layer base wrapper
examples/*/postcss.config.js Removed - no longer needed with Vite plugin
examples/*/package.json Updated dependencies: added @tailwindcss/vite, removed autoprefixer and postcss, upgraded tailwindcss to v4
examples/nextjs/postcss.config.mjs Updated to use object syntax for PostCSS plugin configuration
examples/nextjs/app/globals.css Added @source directives for Next.js-specific paths
examples/ai-nextjs/postcss.config.mjs Updated to use object syntax for PostCSS plugin configuration
examples/ai-nextjs/app/globals.css Added @source directives for Next.js-specific paths
apps/sqlrooms-cli-ui/* Applied same migration pattern as examples
docs/upgrade-guide.md Added comprehensive migration guide for v3 to v4
docs/theming.md Updated CSS examples to remove @layer base wrapper
docs/getting-started.md Updated Tailwind installation instructions to reference v4
README.md Updated Tailwind installation instructions to reference v4
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dmitriy-kostianetskiy dmitriy-kostianetskiy marked this pull request as ready for review January 27, 2026 14:26
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 27, 2026

Too many files changed for review. (199 files found, 100 file limit)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 198 out of 199 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Jan 27, 2026

@dmitriy-kostianetskiy I've opened a new pull request, #327, to work on those changes. Once the pull request is ready, I'll request review from you.

@dmitriy-kostianetskiy
Copy link
Collaborator Author

@copilot can you make sure all deprecated tailwind classes are replaced with the new ones (tailwind v3 -> v4 migration)

Copy link
Contributor

Copilot AI commented Jan 27, 2026

@dmitriy-kostianetskiy I've opened a new pull request, #329, to work on those changes. Once the pull request is ready, I'll request review from you.

* feat: Abort query in CreateTableForm

Signed-off-by: Ilya Boyandin <ilyabo@gmail.com>

* fixes

Signed-off-by: Ilya Boyandin <ilyabo@gmail.com>

* fixes

Signed-off-by: Ilya Boyandin <ilyabo@gmail.com>

---------

Signed-off-by: Ilya Boyandin <ilyabo@gmail.com>
* fix: Prevent type errors in React 18 which don't have `inert`

Signed-off-by: Ilya Boyandin <ilyabo@gmail.com>

* rename isActive -> isSelected for clarity

Signed-off-by: Ilya Boyandin <ilyabo@gmail.com>

---------

Signed-off-by: Ilya Boyandin <ilyabo@gmail.com>
)

* fix: configureKeplerInjector factory resolving was happening early

Signed-off-by: Ilya Boyandin <ilyabo@gmail.com>

* pr feedback

Signed-off-by: Ilya Boyandin <ilyabo@gmail.com>

---------

Signed-off-by: Ilya Boyandin <ilyabo@gmail.com>
lixun910 and others added 6 commits January 28, 2026 13:42
* render reasoning in agent tool; error->Error

* fix ts error
* add a flag for creating layers

* Update packages/kepler/src/KeplerSlice.ts

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

---------

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
* fix: eslint errors

Parsing error: No tsconfigRootDir was set, and multiple candidate TSConfigRootDirs are present.

* chore: add js files to lintstage
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

Important

Review skipped

Too many files!

This PR contains 280 files, which is 130 over the limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/tailwind-v4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@charlieforward9
Copy link
Collaborator

This one is blocking me from using the /recharts package!

@ilyabo
Copy link
Collaborator

ilyabo commented Feb 15, 2026

This one is blocking me from using the /recharts package!

We hope to land it next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments