Fix iteration #4063
Open
Fix iteration #4063
+17
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKleusberg
reviewed
Dec 26, 2025
Member
MKleusberg
left a comment
There was a problem hiding this comment.
This is great! Thank you for taking care of this! 😄 Do you mind fixing the two whitespace issues in this PR? After that we can just merge it easily.
MKleusberg
reviewed
Dec 26, 2025
src/sql/sqlitetypes.cpp
Outdated
| return; | ||
| } | ||
| } else { | ||
| ++it; |
MKleusberg
reviewed
Dec 26, 2025
src/sql/sqlitetypes.cpp
Outdated
| return; | ||
| } | ||
| } else { | ||
| ++it; |
d244174 to
04c3f31
Compare
1 task
This implements the Associative Containers Pattern described at https://stackoverflow.com/questions/16013545/how-do-i-erase-elements-from-stl-containers#16013546. Fixes sqlitebrowser#4061 and sqlitebrowser#4069.
04c3f31 to
72ff25e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the Associative Containers Pattern described at https://stackoverflow.com/questions/16013545/how-do-i-erase-elements-from-stl-containers#16013546.
Fixes #4061.