Skip to content

[StoneDB] Remove implementation #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrigger merged 1 commit into from
Aug 23, 2024
Merged

[StoneDB] Remove implementation #963

mrigger merged 1 commit into from
Aug 23, 2024

Conversation

@malwaregarry
Copy link
Collaborator

@malwaregarry malwaregarry commented Aug 23, 2024

Removing StoneDB from the codebase since the implementation is broken and StoneDB seems to be unmaintained at the moment.
This is part of efforts to improve SQLancer's architecture and codebase in general. If it is being used, we can revert the PR.

@ZhengLin-Li since you worked on this implementation. Do you know whether the StoneDB is still working on the database?

@zhenglin-charlie-li
Copy link
Contributor

zhenglin-charlie-li commented Aug 23, 2024 •
edited
Loading

I'm unsure if StoneDB is still actively maintained.

After joining their Slack community one year ago, I noticed there's been no activity or messages this year. Additionally, their commit history shows that updates haven't been made in quite some time.

@malwaregarry
Copy link
Collaborator Author

malwaregarry commented Aug 23, 2024 •
edited
Loading

alright, are you ok with us removing it for now? @ZhengLin-Li

@zhenglin-charlie-li
Copy link
Contributor

zhenglin-charlie-li commented Aug 23, 2024

alright, are you ok with us removing it for now? @ZhengLin-Li

oh yeah, let's remove

@mrigger
Copy link
Contributor

mrigger commented Aug 23, 2024

Sounds good, we can always re-add by reverting the PR in case development continues.

@malwaregarry, perhaps we could have a table in the README.md that lists implementations that were removed and the corresponding reason?

@malwaregarry
Copy link
Collaborator Author

malwaregarry commented Aug 23, 2024

ok sure, do you want the README.md in this PR or another?

@mrigger
Copy link
Contributor

mrigger commented Aug 23, 2024

Hmm, a separate one would be okay. I guess we could then also reference the removed NoSQL databases (#915).

@mrigger mrigger merged commit a05b0a0 into sqlancer:main Aug 23, 2024
@malwaregarry malwaregarry deleted the remove-stonedb branch August 23, 2024 09:03
malwaregarry added a commit to malwaregarry/sqlancer that referenced this pull request Aug 27, 2024
@malwaregarry
[StoneDB] Remove implementation (sqlancer#963)
9d3246a
malwaregarry added a commit to malwaregarry/sqlancer that referenced this pull request Aug 28, 2024
@malwaregarry
[StoneDB] Remove implementation (sqlancer#963)
edc7499
mgartner pushed a commit to mgartner/sqlancer that referenced this pull request Apr 8, 2025
@malwaregarry @mgartner
[StoneDB] Remove implementation (sqlancer#963)
ede0f0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malwaregarry @zhenglin-charlie-li @mrigger