Don't abort Node on unhandled rejections (#421)#423
Merged
lovasoa merged 1 commit intosql-js:masterfrom Oct 3, 2020
Merged
Conversation
Member
|
Thank you! We should add a test for the new behavior too. |
Contributor
Author
|
I spent a few minutes trying to come up with a test, but I can't get the bug to happen in the tests. I copied an existing test file and replaced its test function with: exports.test = function(sql, assert) {
// Intentionally leak a rejected promise
Promise.reject("failure")
};but that doesn't cause a test failure on the commit before the fix (e1ff5dc). I also tried various tricks to try to wait, in case the process was exiting too fast, but it seems like test functions can't return promises. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #421. Tests pass.