Fix non-multichannel sessions mixing up positional args#129
Merged
J-Jaywalker merged 4 commits intomasterfrom Jun 9, 2025
Merged
Fix non-multichannel sessions mixing up positional args#129J-Jaywalker merged 4 commits intomasterfrom
J-Jaywalker merged 4 commits intomasterfrom
Conversation
Contributor
|
LGTM |
dumitrugutu
approved these changes
Jun 9, 2025
JindrichD
reviewed
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way we were parsing multichannel args meant that unless users were explicitly passing in arguments, we would get a positional mixup.
This change combines stream and channel pairs and stream into a union which is then typechecked later, preserving the way customers currently use the SDK.
Closes https://speechmatics.atlassian.net/browse/DEL-26682