Skip to content

Ensure that x is not unbound in WordEmbeddingEncoder (from Samsung, AI Center, Cambridge)#2905

Merged
TParcollet merged 1 commit intospeechbrain:developfrom
rogiervd:pyright-g2p-unbound
May 13, 2025
Merged

Ensure that x is not unbound in WordEmbeddingEncoder (from Samsung, AI Center, Cambridge)#2905
TParcollet merged 1 commit intospeechbrain:developfrom
rogiervd:pyright-g2p-unbound

Conversation

@rogiervd
Copy link
Contributor

@rogiervd rogiervd commented May 13, 2025

What does this PR do?

I believe that this fixes a bug in WordEmbeddingEncoder.forward when self.norm is None. I believe x would have been unbound.

I found this with Pyright (see #2901).

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

TParcollet
TParcollet approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@TParcollet TParcollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. LGTM

@TParcollet TParcollet merged commit 2d014fe into speechbrain:develop May 13, 2025
5 checks passed
pplantinga pushed a commit to pplantinga/speechbrain that referenced this pull request Jun 2, 2025
@rogiervd @pplantinga
Ensure that x is not unbound in WordEmbeddingEncoder (from Samsung, A…
a8bb39d 
…I Center, Cambridge) (speechbrain#2905)

Co-authored-by: Rogier van Dalen <r.vandalen@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TParcollet TParcollet TParcollet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rogiervd @TParcollet