Updating CommonVoice CTC English and Conformer English#2560
Merged
TParcollet merged 51 commits intospeechbrain:developfrom Jun 26, 2024
Merged
Updating CommonVoice CTC English and Conformer English#2560TParcollet merged 51 commits intospeechbrain:developfrom
TParcollet merged 51 commits intospeechbrain:developfrom
Conversation
added 8 commits
February 26, 2024 12:20
added 2 commits
June 3, 2024 13:33
Collaborator
Author
|
@Adel-Moumen is ready to review and merge. The conformer WER is not there yet, but I'll edit the readme directly on the main repo once the decoding is done :p |
Adel-Moumen
reviewed
Jun 6, 2024
Collaborator
Adel-Moumen
left a comment
There was a problem hiding this comment.
hi, overall lgtm. I leaved one comment about avoid_if_longer_than_val_test.
Comment on lines
+283
to
+286
| test_data = test_data.filtered_sorted( | ||
| sort_key="duration", | ||
| key_max_value={"duration": hparams["avoid_if_longer_than_val_test"]}, | ||
| ) |
Collaborator
There was a problem hiding this comment.
I think we should definitely add a warning/log saying that we are skipping files that have a duration > to avoid_if_longer_than_val_test.
Collaborator
Author
|
I merge cuz I'm the boss blblblblb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CTC en recipes and Conformer EN recipes were way out of date.
Now we have something a bit better.
Models are training, i'll update the results.