fix endless doctest despite no example#1591
Merged
Adel-Moumen merged 1 commit intodevelopfrom Oct 4, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent testing for a PR ran endlessly, and was cancelled after 6h.
see: https://github.com/speechbrain/speechbrain/actions/runs/3175083475/jobs/5182679440
A second re-run took 45min, then I cancelled that workflow, too.
After running doctests locally, it came clear that
caused the issue - BUT - this file does not have any doctest examples !!
When I found this
pytest-dev/pytest#2188 (comment)
I checked the file again for anything that could potentially knock off the doctest-module collection and found the function
-> does it work to simply rename this one?
It did...