Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: speechbrain/speechbrain
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: develop
Choose a base ref
...
head repository: speechbrain/speechbrain
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release-v1.0.0
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 4 files changed
  • 2 contributors

Commits on Sep 19, 2024

  1. Mock some dependencies for docs

    @asumagic @pplantinga
    asumagic authored and pplantinga committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    24123b6 View commit details
    Browse the repository at this point in the history

  2. readthedocs fix attempt (#2443)

    @asumagic @pplantinga
    asumagic authored and pplantinga committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    56d5c72 View commit details
    Browse the repository at this point in the history

  3. Remove incorrect image: latest key for readthedocs

    @asumagic @pplantinga
    asumagic authored and pplantinga committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    684c247 View commit details
    Browse the repository at this point in the history

  4. Add readthedocs-requirements.txt to work around error in rtd

    @asumagic @pplantinga
    asumagic authored and pplantinga committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    dc480e7 View commit details
    Browse the repository at this point in the history

  5. Pin torch and k2 version specifically in readthedocs-requirements.txt 

    We would rather not pin PyTorch and k2 in the docs-requirements (esp as the package to install depends on whether you want CPU or CUDA), so this is added to the new rtd requirements file instead. This is not ideal but I don't see much of a clean way around this.
    @asumagic @pplantinga
    asumagic authored and pplantinga committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    58edb0f View commit details
    Browse the repository at this point in the history

  6. omfg requirements.txt have linters too

    @asumagic @pplantinga
    asumagic authored and pplantinga committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    efb2536 View commit details
    Browse the repository at this point in the history

  7. Precommit fix again

    @asumagic @pplantinga
    asumagic authored and pplantinga committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    06a63dd View commit details
    Browse the repository at this point in the history

  8. Remove requirement that causes broken docs build

    @pplantinga
    pplantinga committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a8b67d9 View commit details
    Browse the repository at this point in the history
Loading