Fix(core): Ensure Python 3.8+ compatibility by using ast.Constant#31
Merged
pplantinga merged 4 commits intospeechbrain:mainfrom Jan 1, 2026
Merged
Fix(core): Ensure Python 3.8+ compatibility by using ast.Constant#31pplantinga merged 4 commits intospeechbrain:mainfrom
pplantinga merged 4 commits intospeechbrain:mainfrom
Conversation
Updated the _ast_eval function to handle ast.Constant nodes for compatibility with Python 3.8 and newer, where ast.Num is deprecated. This ensures correct evaluation of constants across Python versions.
Adds Python 3.13 to the test matrix and updates actions/checkout and actions/setup-python to their latest major versions for improved compatibility and security.
Replaces Python 3.13 with 3.14 in the GitHub Actions matrix to ensure compatibility and testing with the latest Python release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using this library on Python 3.14, I encountered this error:
This PR fixes this error on Python 3.14+ and enhances the CI to ensure multi-version compatibility, including for Python 3.14. The changes should make the library more robust and future-proof.
Problem
The
_ast_evalfunction usesast.Numto evaluate numeric nodes, which is incompatible with modern Python versions.According to the official documentation, the
ast.Numclass (along withast.Str,ast.Bytes, etc.) was deprecated in Python 3.8 and scheduled for future removal. Starting in Python 3.8,ast.Constantbecame the unified node for all constants.The original
AttributeErroron newer Python versions is a direct consequence of this deprecation and subsequent removal, causinghyperpyyamlto fail when parsing arithmetic references.Solution
This patch resolves the issue by implementing a version-aware check within the
_ast_evalfunction inhyperpyyaml/core.py:ast.Constantand accesses its value via the.valueattribute.ast.Numand using the.nattribute.This approach ensures the library remains fully backward-compatible while supporting all modern Python interpreters.
Additional Improvements