Skip to content

fix(mcp): align provider guidance with catalog format - #451

Merged
lgalabru merged 1 commit into
solana-foundation:mainfrom
JasonColapietro:fix/catalog-provider-guidance
Sep 1, 2026
Merged

fix(mcp): align provider guidance with catalog format#451
lgalabru merged 1 commit into
solana-foundation:mainfrom
JasonColapietro:fix/catalog-provider-guidance

Conversation

@JasonColapietro

@JasonColapietro JasonColapietro commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • make create_skill accept the current provider directory layout ending in PAY.md
  • emit current pay catalog check commands instead of removed pay skills commands
  • update the bundled monetization reference for committed OpenAPI sidecars, current categories, and catalog validation
  • remove the obsolete provider sync recommendation from the MCP tool description

Problem

The MCP helper still generated and validated the legacy flat provider layout. A contributor following it would produce paths and commands rejected by the current pay-skills catalog workflow.

Verification

  • cargo test -p pay-mcp: 107 passed, 3 ignored
  • cargo test -p pay-mcp --doc
  • cargo fmt --all --check
  • git diff --check

The output-path tests were updated first and failed against the old implementation, then passed with this change.

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

@JasonColapietro is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown

Greptile Summary

This change aligns MCP provider-authoring guidance with the PAY.md catalog layout, committed OpenAPI sidecars, and current pay catalog validation commands.

A compatibility concern was disproved by execution: a provider at providers/acme/search/PAY.md with name: search and an adjacent openapi.json referenced through openapi: { path: openapi.json } successfully built into a catalog entry with its endpoint resolved. The focused MCP output-path tests also accepted both native and proxied PAY.md layouts.

No defects were found.

Confidence Score: 5/5

Safe to merge based on focused catalog-build and MCP path-validation coverage.

The exercised provider layout, parent-directory name check, and relative OpenAPI sidecar resolution all behaved as documented, and no final findings remain.

Files Needing Attention: No files need further attention.

T-Rex T-Rex Logs

What T-Rex did

  • Ran the focused MCP output-path tests, which passed all three checks for the documented native and proxied PAY.md provider layouts.
  • Ran a focused catalog-build test that created providers/acme/search/PAY.md and an adjacent openapi.json, then built the provider with probing disabled; the test passed and resolved the sidecar into one endpoint.
  • The documented PAY.md layout and the relative openapi.path behavior therefore match the registry implementation.
  • Registry build code discovers PAY.md, checks its parent directory against the name, and calls the relative OpenAPI resolver with PAY.md's parent directory; the focused test passed with exit code 0.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "fix(mcp): align provider guidance with c..." | Re-trigger Greptile

lgalabru
lgalabru approved these changes Sep 1, 2026
View reviewed changes

@lgalabru lgalabru left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @JasonColapietro!

@lgalabru
lgalabru merged commit 1200945 into solana-foundation:main Sep 1, 2026
9 of 10 checks passed
This was referenced Sep 6, 2026
Merged
Merged
JasonColapietro added a commit to Suede-AI/suedeai-org that referenced this pull request Sep 6, 2026
@JasonColapietro
record: 41 pull requests merged across 38 projects (#82)
31606d7 
GitHub search on 2026-09-05 returns 41 merged pull requests by the JasonColapietro account outside its own repositories, across 38 repositories: 26 substantive fixes, features, tests, and docs across 24 repositories, plus 15 accepted listings of Suede projects across 15. The four since the Sep 1 count of 37 across 34: paritytech/polkadot-sdk#12853, solana-foundation/pay#451, solana-foundation/pay-kit#299, and davepoon/buildwithclaude#305.

The public record and the split live at https://seo.suedeai.ai/evidence#open-source and on https://github.com/JasonColapietro; the accomplishments ledger changes in the same pass.
JasonColapietro added a commit to JasonColapietro/sing that referenced this pull request Sep 6, 2026
@JasonColapietro
record: 41 pull requests merged across 38 external repositories (#134)
360e65e 
GitHub search on 2026-09-05 returns 41 merged pull requests by the JasonColapietro account outside its own repositories, across 38 repositories: 26 substantive fixes, features, tests, and docs across 24 repositories, plus 15 accepted listings of Suede projects across 15. The four since the Sep 1 count of 37 across 34: paritytech/polkadot-sdk#12853, solana-foundation/pay#451, solana-foundation/pay-kit#299, and davepoon/buildwithclaude#305.

The public record and the split live at https://seo.suedeai.ai/evidence#open-source and on https://github.com/JasonColapietro; the accomplishments ledger changes in the same pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgalabru lgalabru lgalabru approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JasonColapietro @lgalabru