[Visual] Scene center and radius are not longer cached#5976
Open
alxbilger wants to merge 3 commits intosofa-framework:masterfrom
Open
[Visual] Scene center and radius are not longer cached#5976alxbilger wants to merge 3 commits intosofa-framework:masterfrom
alxbilger wants to merge 3 commits intosofa-framework:masterfrom
Conversation
This avoids a case where it was used but not yet defined.
fredroy
approved these changes
Mar 3, 2026
Lucas-TJ
approved these changes
Mar 5, 2026
Contributor
Author
|
[ci-build][with-all-tests][force-full-build] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the cache mechanism around the scene center and radius in the
BaseCameraclass.Removed:
sceneCenterandsceneRadiusare removed. This is breaking for derived class using them.Added:
Changes:
Effects:
sceneCenterwas used, but it was not already computed and cached. Therefore, the default value was used (likely zero). The default value was then used to compute Znear and Zfar, resulting both to be set to zero. At some point there is a division by(currentZFar - currentZNear), leading to a nan.Before:

After:

Note that I don't understand why having nan is not problematic. I am not sure neither if having valid values helps.
I took the opportunity to add easy constness to some methods.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if