Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-client-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: socketio/socket.io-client-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Dec 17, 2021

  1. fix: fix emitting of events received during connection establishment (#…

    …695)
    
    Previously, the event name of packets received during the connection
    handshake would not be removed from the arguments array:
    
    ```java
    socket.on("my-event", new Emitter.Listener() {
        @OverRide
        public void call(Object... args) {
            System.out.println(Arrays.toString(args)); // prints ["my-event", "arg1", "arg2", "arg3"]
        }
    });
    ```
    yifucc authored Dec 17, 2021
    Configuration menu
    Copy the full SHA
    832a609 View commit details
    Browse the repository at this point in the history
Loading