[ENH] SubsetResampling issue #5. - #9
Open
CarloNicolini wants to merge 1 commit into
Open
CarloNicolini wants to merge 1 commit into
CarloNicolini wants to merge 1 commit into
Conversation
…egressor, following issue skfolio#5.
Member
|
The lint issue has been fixed, the tests should pass the ruff check now |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Collaborator
Author
|
@HugoDelatte all checks are passed, please take a look if everything complies with library standards. Maybe we should add this case to the examples section too, otherwise feel free to close the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Added SubsetResampling estimator for bagging on features of a general portfolio estimator as discussed in discussion #5
What does this implement/fix? Explain your changes.
A new estimator called SubsetResampling method as discussed in this blog post:
https://blog.thinknewfound.com/2018/07/machine-learning-subset-resampling-and-portfolio-optimization
Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
Checking that the newly written estimator complies with all the properties of a proper portfolio estimator.
Did you add any tests for the change?
I added a test_subsetresampling under a new section _bagging in the proper
test/test_optimization/test_ensemble/test_subsetresampling.py.The test checks everything works with 10 independent features subsets using the minimum variance portfolio.
Any other comments?
Authors of the subset resampling method suggest to set max_features=n^0.8 where n in the total number of assets, this has not been added in the class documentation.
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skfolioroot directory (not theCONTRIBUTORS.md).For new estimators
docs/api.rst: ✅examplessection. ❌