Remove deprecated ignore-init-module-imports from Ruff configuration#2667
Open
cjemorton wants to merge 2 commits intosimple-login:masterfrom
Open
Remove deprecated ignore-init-module-imports from Ruff configuration#2667cjemorton wants to merge 2 commits intosimple-login:masterfrom
cjemorton wants to merge 2 commits intosimple-login:masterfrom
Conversation
Co-authored-by: cjemorton <2660596+cjemorton@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Remove deprecated
ignore-init-module-importsfrom Ruff configurationSummary
This PR removes the deprecated
ignore-init-module-importsconfiguration option from Ruff's settings inpyproject.toml, eliminating unnecessary deprecation warnings and aligning with Ruff's current best practices.Problem
The current Ruff configuration contains a deprecated option that generates warnings:
This option is no longer necessary as Ruff now correctly handles imports in
__init__.pyfiles by default. The deprecation warning appears during any Ruff operation (linting, formatting, checking), creating noise in development workflows and CI/CD pipelines.Changes
This PR makes a single, surgical change:
File:
pyproject.toml[tool.ruff] exclude = [".venv", "migrations", "app/events/generated"] [tool.ruff.lint] -ignore-init-module-imports = trueLines changed: 1 deletion
Files changed: 1
Why This Change is Needed
Testing
This change has been tested and verified:
Commands tested:
Impact
Additional Notes
References
__init__.pyimports has been improved to work correctly by defaultChecklist: