Skip to content

Conversation

@nfischer
Copy link
Member

@nfischer nfischer commented Dec 7, 2023

This changes the README to use a standard shields.io badge for GitHub Actions. The custom badge
(https://github.com/Atrox/github-actions-badge) was cool, but the atrox.dev link doesn't work reliably. I noticed that shields has support for this now, so there's no reason to use a custom badge.

One notably difference is that this badge says the build is passing even if there's a job still in progress.

@nfischer nfischer added the docs label Dec 7, 2023
@codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85dd472) 96.47% compared to head (f248b0a) 97.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1145      +/-   ##
==========================================
+ Coverage   96.47%   97.27%   +0.80%     
==========================================
  Files          36       36              
  Lines        1360     1360              
==========================================
+ Hits         1312     1323      +11     
+ Misses         48       37      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This changes the README to use a standard shields.io badge for GitHub
Actions. The custom badge
(https://github.com/Atrox/github-actions-badge) was cool, but the
atrox.dev link doesn't work reliably. I noticed that shields has support
for this now, so there's no reason to use a custom badge.

One notably difference is that this badge says the build is passing even
if there's a job still in progress.
@nfischer nfischer merged commit a6d1e49 into master Dec 7, 2023
@nfischer nfischer deleted the doc-github-badge branch December 7, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants