Clamp rect origin point and size after scaling#4879
Closed
BudiArb wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Budiman Arbenta <arbenta6@gmail.com>
yezhizhen
reviewed
Jan 27, 2026
yezhizhen
left a comment
Member
There was a problem hiding this comment.
Emm, I wonder if such change should be made in upstream instead?
cc @mrobinson
bfd0b6b to
8c1bfc3
Compare
Member
|
Yes, let's try to get this upstream first, as it is not really related to Servo. |
pull Bot
pushed a commit
to Haofei/servo
that referenced
this pull request
Apr 23, 2026
…isplay list item properties instead of `MaxRect` (servo#44457) Mobile phone runs OpenGL Embedded System. The precision is limited comparing to Desktop which runs full OpenGL. This caused a bug where box-shadow is not displayed on Android/OHOS. Instead of using an infinite clip rect, we compute a bounded one. This should save some GPU work as well. Reference: [How to gracefully handle highp/mediump switch for mobile Android browsers?](https://discourse.threejs.org/t/how-to-gracefully-handle-highp-mediump-switch-for-mobile-android-browsers/77335) Testing: Desktop WPT [unchanged](https://github.com/servo/servo/actions/runs/24825758325). Manually tested on Android/Ohos. Now look same as Firefox/Chrome. | Before | After | | -------- | -------- | |  |  | Fixes: servo#44431 Closes: servo/webrender#4879 --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clamp rect origin point and size after scaling to prevent overflowing of f32 numbers