Skip to content

Switch to fork of debug_unreachable#206

Merged
bors-servo merged 1 commit into
servo:masterfrom
mbrubeck:debug_unreachable
Jun 4, 2018
Merged

Switch to fork of debug_unreachable#206
bors-servo merged 1 commit into
servo:masterfrom
mbrubeck:debug_unreachable

Conversation

@mbrubeck

@mbrubeck mbrubeck commented Jun 3, 2018

Copy link
Copy Markdown
Contributor

Because the original debug_unreachable is abandoned and doesn't work correctly in modern Rust.


This change is Reviewable

@KiChjang

KiChjang commented Jun 3, 2018

Copy link
Copy Markdown
Contributor

Is the repository located here https://github.com/mbrubeck/rust-debug-unreachable ? Because the one at crates.io redirects back to reem's repo and not yours, and I don't seem to see any code changes in your fork.

@mbrubeck

mbrubeck commented Jun 3, 2018

Copy link
Copy Markdown
Contributor Author

Yes, that's the repository. The code for the fork is in the fork branch. I've updated the repo link on crates.io.

Because the original debug_unreachable is abandoned and doesn't work correctly in modern Rust.
@mbrubeck mbrubeck force-pushed the debug_unreachable branch from ee3f73a to 007c826 Compare June 3, 2018 16:03
@KiChjang

KiChjang commented Jun 4, 2018

Copy link
Copy Markdown
Contributor

@bors-servo r+

@bors-servo

Copy link
Copy Markdown
Contributor

📌 Commit 007c826 has been approved by KiChjang

@bors-servo

Copy link
Copy Markdown
Contributor

⌛ Testing commit 007c826 with merge e838e1c...

bors-servo pushed a commit that referenced this pull request Jun 4, 2018
Switch to fork of debug_unreachable

Because the original debug_unreachable is abandoned and doesn't work correctly in modern Rust.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/206)
<!-- Reviewable:end -->
@bors-servo

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-travis
Approved by: KiChjang
Pushing e838e1c to master...

@bors-servo bors-servo merged commit 007c826 into servo:master Jun 4, 2018
@mbrubeck

mbrubeck commented Jun 5, 2018

Copy link
Copy Markdown
Contributor Author

Published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants