Skip to content

fonts: Remove redundant hardcoded_font_families for ohos#45296

Merged
TimvdLippe merged 1 commit into
servo:mainfrom
RichardTjokroutomo:ohos-chore
Jun 2, 2026
Merged

fonts: Remove redundant hardcoded_font_families for ohos#45296
TimvdLippe merged 1 commit into
servo:mainfrom
RichardTjokroutomo:ohos-chore

Conversation

@RichardTjokroutomo

@RichardTjokroutomo RichardTjokroutomo commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Removed hardcoded_font_families(), which is previously used to create FontFamily for HarmonyOS emoji fonts (HMOS Color Emoji & HMOS Color Emoji Flags). This function is no longer needed since #44061 because we're now using OHOS API to generate FontList, which can detect all available system fonts, including the emoji ones.

Testing: Manually tested.
Fixes: N/A

Signed-off-by: Richard Tjokroutomo <richard.tjokro2@gmail.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 2, 2026
@RichardTjokroutomo

Copy link
Copy Markdown
Contributor Author

cc @jschwe

@yezhizhen yezhizhen changed the title chore: removed redundant function from ohos' font_list.rs fonts: Remove redundant hardcoded_font_families for ohos Jun 2, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jun 2, 2026
@yezhizhen yezhizhen added this pull request to the merge queue Jun 2, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 2, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jun 2, 2026
@TimvdLippe TimvdLippe added this pull request to the merge queue Jun 2, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jun 2, 2026
Merged via the queue into servo:main with commit d479625 Jun 2, 2026
42 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants