script_bindings: Port call_setup to use &mut JSContext#44626
Merged
Conversation
TimvdLippe
approved these changes
Apr 30, 2026
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
Love to see this! For xpath you send a follow-up PR?
Contributor
Author
|
I think @jdm wanted to review it, otherwise we can go ahead. |
Contributor
|
Let's wait on Josh in that case. |
Contributor
Author
I think it's the same of #42839, not sure how much effort it will require passing it around. |
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
jdm
approved these changes
Apr 30, 2026
jdm
left a comment
Member
There was a problem hiding this comment.
Looks like what I expected! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callback methods have now access to
&mut JSContext, an additionaltemp_cxwas needed forXPathtrait.Testing: It compiles
Part of #42638