Skip to content

Update uv.lock for #44591#44600

Merged
delan merged 4 commits into
mainfrom
update-uv-lock
May 1, 2026
Merged

Update uv.lock for #44591#44600
delan merged 4 commits into
mainfrom
update-uv-lock

Conversation

@delan

@delan delan commented Apr 29, 2026

Copy link
Copy Markdown
Member

#44591 bumps pyrefly to 0.63.1, but uv.lock still lists pyrefly 0.23.1. as a result, when mach runs uv run --frozen, we still try to install the old version of pyrefly, which fails on FreeBSD (#44589).

this patch updates uv.lock by running uv lock, on a Linux machine. for some reason, if i run uv lock on a FreeBSD machine, uv just removes pyrefly from uv.lock, which is probably not what we want.

Testing: tested manually on FreeBSD (it takes an eternity to build pyrefly though!)

@delan delan requested a review from mrobinson April 29, 2026 11:37
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 29, 2026

@mrobinson mrobinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 29, 2026
@jschwe

jschwe commented Apr 30, 2026

Copy link
Copy Markdown
Member

Looks like the pyrefly version had an API change, so we would need to update mach (see failing tidy error).

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 30, 2026
@mukilan

mukilan commented Apr 30, 2026

Copy link
Copy Markdown
Member

I've fixed the new type errors in 145b971. I think delan needs to signoff the original commit (fede700) for DCO check.

delan and others added 4 commits May 1, 2026 11:03
Signed-off-by: delan azabani <dazabani@igalia.com>
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Signed-off-by: delan azabani <dazabani@igalia.com>
Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
Signed-off-by: delan azabani <dazabani@igalia.com>
Signed-off-by: delan azabani <dazabani@igalia.com>
@delan delan force-pushed the update-uv-lock branch from 145b971 to e14b5dd Compare May 1, 2026 03:07
@delan

delan commented May 1, 2026

Copy link
Copy Markdown
Member Author

thanks everyone!

@delan delan enabled auto-merge May 1, 2026 03:07
@delan delan added this pull request to the merge queue May 1, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 1, 2026
Merged via the queue into main with commit f73f72a May 1, 2026
30 checks passed
@delan delan deleted the update-uv-lock branch May 1, 2026 03:52
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants