script: Replace some usage of children() with children_unrooted() in script/dom/execcommand by Narfinger · Pull Request #44544 · servo/servo

Narfinger · 2026-04-27T13:20:46Z

This replaces some usages of children() with children_unrooted() for more efficiency in execcommand, htmlfieldsetelement and htmlmediaelement.

We also implement PartialEq<Root<Dom>> for UnrootedDom<'_,T>.

Safety is enforced by taking a &JSContext.

Testing: Compilation is the test for these changes.

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>

Narfinger · 2026-04-27T15:32:24Z

Not sure how to fix the lint.

jdm · 2026-04-28T00:45:54Z

Not sure how to fix the lint.

Can you change the PartialEq to be &T instead of &Root<Dom<T>>? The Dom::from_ref will still work; the question is whether the == checks will still compile without changes.

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>

Narfinger · 2026-04-28T11:03:32Z

Oh. That looks like changed behavior.

github-actions · 2026-04-28T11:07:39Z

🔨 Triggering try run (#25049245635) for Linux (WPT)

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>

github-actions · 2026-04-28T11:48:43Z

Test results for linux-wpt from try job (#25049245635):

Flaky unexpected result (38)

OK /IndexedDB/idbdatabase_deleteObjectStore.any.worker.html (#43776)
- FAIL [expected PASS] subtest: Deleted object store's name should be removed from database's list. Attempting to use a deleted IDBObjectStore should throw an InvalidStateError
```
assert_unreached: rq_add.error (DataError) Reached unreachable code
```
OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- PASS [expected FAIL] subtest: WebGL test #45
- PASS [expected FAIL] subtest: WebGL test #47
- PASS [expected FAIL] subtest: WebGL test #49
- PASS [expected FAIL] subtest: WebGL test #51
CRASH [expected OK] /_webgl/conformance2/wasm/readpixels-2gb-in-4gb-wasm-memory.html
CRASH [expected OK] /content-security-policy/meta/sandbox-iframe.html (#43478)
FAIL [expected PASS] /css/css-backgrounds/background-size-041.html
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 2
CRASH [expected OK] /fetch/api/request/request-cache-reload.any.worker.html
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/sandboxed-iframe.https.window.html (#41704)
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - Not sent to non-trustworthy same-origin destination
```
Test timed out
```
ERROR [expected OK] /fetch/metadata/window-open.https.sub.html (#40339)
OK [expected ERROR] /focus/focus-event-after-switching-iframes.sub.html (#40368)
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- PASS [expected FAIL] subtest: Link with onclick navigation and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-204.html (#44521)
- PASS [expected FAIL] subtest: Navigating to a different document with link click
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace

OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-requestsubmit.html (#44098)

FAIL [expected TIMEOUT] subtest: Replace before load, triggered by formElement.requestSubmit()

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement=" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20form%20%3D%20document.createElement(%22form%22)%3B%0A%20%20%20%20form.action%20%3D%20%22%2Fcommon%2Fblank.html%22%3B%0A%0A%20%20%20%20const%20input%20%3D%20document.createElement(%22input%22)%3B%0A%20%20%20%20input.type%20%3D%20%22hidden%22%3B%0A%20%20%20%20input.name%20%3D%20%22thereplacement%22%3B%0A%20%20%20%20form.append(input)%3B%0A%0A%20%20%20%20document.currentScript.before(form)%3B%0A%20%20%20%20form.requestSubmit()%3B%0A%20%20"

OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected OK] /html/browsers/history/the-location-interface/scripted_form_submit_assign_during_load.html
OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- TIMEOUT [expected FAIL] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
Test timed out
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html (#39694)
- PASS [expected FAIL] subtest: Meta refresh is blocked by the allow-scripts sandbox flag at its creation time, not when refresh comes due
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- FAIL [expected PASS] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
```
uncaught exception: Error: assert_unreached: The iframe into which the meta was moved must not refresh Reached unreachable code
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
- PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.

OK /html/semantics/scripting-1/the-script-element/execution-timing/077.html (#22139)

FAIL [expected PASS] subtest: adding several types of scripts through the DOM and removing some of them confuses scheduler

assert_array_equals: expected property 1 to be "Script #1 ran" but got "Script #3 ran" (expected array ["Script #2 ran", "Script #1 ran", "Script #3 ran", "Script #4 ran"] got ["Script #2 ran", "Script #3 ran", "Script #4 ran", "Script #1 ran"])

TIMEOUT [expected OK] /html/user-activation/navigation-state-reset-sameorigin.html
- TIMEOUT [expected PASS] subtest: Post-navigation state reset.
```
Test timed out
```
OK /html/user-activation/propagation-same-and-cross-origin.sub.html
- FAIL [expected PASS] subtest: Check that activating a same-origin navigable doesn't activate a cross origin navigable
```
assert_true: top-frame navigator.userActivation.isActive must be true expected true got false
```
TIMEOUT [expected OK] /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html
- NOTRUN [expected PASS] subtest: touch two-finger pan on 'touch-action: pan-x pan-y'
- NOTRUN [expected FAIL] subtest: touch two-finger pan on 'touch-action: pinch-zoom'
ERROR /service-workers/idlharness.https.any.html (#36250)
- PASS [expected TIMEOUT] subtest: ServiceWorkerContainer interface: operation register((TrustedScriptURL or USVString), optional RegistrationOptions)
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation enable()
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation disable()
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation setHeaderValue(ByteString)
- PASS [expected TIMEOUT] subtest: NavigationPreloadManager interface: operation getState()
TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
OK /webdriver/tests/classic/element_click/center_point.py
- FAIL [expected PASS] subtest: test_entirely_in_view
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/element_click/events.py
- FAIL [expected PASS] subtest: test_event_mousemove
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/element_click/file_upload.py
- FAIL [expected PASS] subtest: test_file_upload_state
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/execute_async_script/collections.py
- FAIL [expected PASS] subtest: test_arguments
```
AssertionError: no such window (404): No such window
```
OK /webdriver/tests/classic/get_active_element/get.py
- ERROR [expected PASS] subtest: test_no_top_browsing_context
```
setup error: webdriver.error.NoSuchElementException: no such element (404)
```
OK /webdriver/tests/classic/get_element_tag_name/get.py
- ERROR [expected PASS] subtest: test_no_top_browsing_context
```
setup error: webdriver.error.NoSuchElementException: no such element (404)
```
OK /webdriver/tests/classic/perform_actions/key_modifiers.py
- ERROR [expected PASS] subtest: test_shift_modifier_and_non_printable_keys[\ue008]
```
setup error: webdriver.error.NoSuchWindowException: no such window (404): No such window
```

Stable unexpected results that are known to be intermittent (21)

TIMEOUT [expected OK] /_mozilla/mozilla/window-resize-event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /css/css-cascade/layer-cssom-order-reverse.html (#36094)
- PASS [expected FAIL] subtest: Delete layer invalidates @font-face
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
```
assert_equals: quoted fantasy matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted monospace (drawing text in a canvas)
```
assert_equals: quoted monospace matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted math (drawing text in a canvas)
```
assert_equals: unquoted math does not match @font-face rule expected 40 but got 125
```
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai) (drawing text in a canvas)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(khmer-mul) (drawing text in a canvas)
```
assert_equals: quoted generic(khmer-mul) matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted ui-serif (drawing text in a canvas)
```
assert_equals: quoted ui-serif matches  @font-face rule expected 125 but got 40
```
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/empty-payload.https.window.html (#35176)
ERROR [expected OK] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- FAIL [expected PASS] subtest: sec-fetch-mode
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit.html (#44028)
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)
- PASS [expected FAIL] subtest: opener of discarded auxiliary browsing context

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

assert_equals: expected Element node &lt;area autofocus="" href="/common/blank.html"&gt;&lt;/area&gt; but got Element node &lt;body&gt;
&lt;img src="/media/poster.png" usemap="#map"&gt;
&lt;map n...

OK /html/semantics/embedded-content/media-elements/seeking/seek-to-max-value.htm (#40626)
- PASS [expected FAIL] subtest: seek to Number.MAX_VALUE
OK /html/semantics/scripting-1/the-script-element/module/choice-of-error-1.html (#44058)
- FAIL [expected PASS] subtest: Parse errors in different files should be reported depending on different roots
```
assert_not_equals: two different parse errors should be reported got disallowed value object "SyntaxError: expected expression, got '%'"
```
OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.worker.html (#33909)
- PASS [expected FAIL] subtest: Revoking a blob URL immediately after calling import will not fail
TIMEOUT [expected OK] /infrastructure/testdriver/click_nested.html (#43887)
- NOTRUN [expected FAIL] subtest: TestDriver click method with multiple windows and nested iframe
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
```
assert_true: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
```
assert_true: Reload domContentLoadedEventStart &gt; Original domContentLoadedEventStart expected true got false
```
- FAIL [expected PASS] subtest: Reload domInteractive > Original domInteractive
```
assert_true: Reload domInteractive &gt; Original domInteractive expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```
OK /resource-timing/buffer-full-then-increased.html (#44408)
- FAIL [expected PASS] subtest: Test that overflowing the buffer and immediately increasing its limit does not trigger the resourcetimingbufferfull event
```
assert_equals: Number of entries does not match the expected value. expected 3 but got 1
```
OK /resource-timing/test_resource_timing.html (#25720)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (iframe)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (script)
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- PASS [expected FAIL] subtest: Click event should be fired when touchend opens synchronous XHR
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK /trusted-types/trusted-types-reporting.html (#43737)
- PASS [expected FAIL] subtest: Trusted Type violation report: sample for custom element assignment
- PASS [expected FAIL] subtest: Trusted Type violation report: Worker constructor
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)

Stable unexpected results (2)

OK /editing/run/delete.html?1001-2000

FAIL [expected PASS] subtest: [["delete",""]] "foo<br><table><tr><td>[]bar</table>baz" compare innerHTML

assert_equals: Unexpected innerHTML (after normalizing inline style) expected "foo&lt;table&gt;&lt;tbody&gt;&lt;tr&gt;&lt;td&gt;bar&lt;/td&gt;&lt;/tr&gt;&lt;/tbody&gt;&lt;/table&gt;baz" but got "foo&lt;br&gt;&lt;table&gt;&lt;tbody&gt;&lt;tr&gt;&lt;td&gt;bar&lt;/td&gt;&lt;/tr&gt;&lt;/tbody&gt;&lt;/table&gt;baz"

PASS [expected FAIL] subtest: [["delete",""]] "foo<br><br><table><tr><td>[]bar</table>baz" compare innerHTML

OK /editing/run/delete.html?2001-3000

FAIL [expected PASS] subtest:

[["defaultparagraphseparator","div"],["delete",""]] "&lt;div&gt;&lt;div&gt;&lt;p&gt;foo&lt;/p&gt;&lt;/div&gt;&lt;/div&gt;&lt;div&gt;&lt;!--abc--&gt;&lt;div&gt;&lt;div&gt;[]bar&lt;/div&gt;&lt;/div&gt;&lt;/div&gt;" compare innerHTML

assert_equals: Unexpected innerHTML (after normalizing inline style) expected "&lt;div&gt;&lt;div&gt;&lt;p&gt;foobar&lt;/p&gt;&lt;/div&gt;&lt;/div&gt;" but got "&lt;div&gt;&lt;div&gt;&lt;p&gt;foo&lt;/p&gt;&lt;/div&gt;&lt;/div&gt;&lt;div&gt;&lt;div&gt;&lt;div&gt;&lt;/div&gt;&lt;/div&gt;bar&lt;/div&gt;"

FAIL [expected PASS] subtest:

[["defaultparagraphseparator","p"],["delete",""]] "&lt;div&gt;&lt;div&gt;&lt;p&gt;foo&lt;/p&gt;&lt;/div&gt;&lt;/div&gt;&lt;div&gt;&lt;!--abc--&gt;&lt;div&gt;&lt;div&gt;[]bar&lt;/div&gt;&lt;/div&gt;&lt;/div&gt;" compare innerHTML

assert_equals: Unexpected innerHTML (after normalizing inline style) expected "&lt;div&gt;&lt;div&gt;&lt;p&gt;foobar&lt;/p&gt;&lt;/div&gt;&lt;/div&gt;" but got "&lt;div&gt;&lt;div&gt;&lt;p&gt;foo&lt;/p&gt;&lt;/div&gt;&lt;/div&gt;&lt;div&gt;&lt;div&gt;&lt;div&gt;&lt;/div&gt;&lt;/div&gt;bar&lt;/div&gt;"

github-actions · 2026-04-28T11:48:52Z

⚠️ Try run (#25049245635) failed!

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>

github-actions · 2026-04-28T12:10:48Z

🔨 Triggering try run (#25051844711) for Linux (WPT)

github-actions · 2026-04-28T12:59:23Z

Test results for linux-wpt from try job (#25051844711):

Flaky unexpected result (38)

OK /IndexedDB/idbdatabase_deleteObjectStore.any.html (#43823)
- PASS [expected FAIL] subtest: Deleted object store's name should be removed from database's list. Attempting to use a deleted IDBObjectStore should throw an InvalidStateError
OK /IndexedDB/idbdatabase_deleteObjectStore.any.worker.html (#43776)
- FAIL [expected PASS] subtest: Deleted object store's name should be removed from database's list. Attempting to use a deleted IDBObjectStore should throw an InvalidStateError
```
assert_unreached: rq_add.error (DataError) Reached unreachable code
```
OK /_mozilla/mozilla/getBoundingClientRect.html
- FAIL [expected PASS] subtest: getBoundingClientRect 1
```
assert_equals: expected 62 but got 60.35
```
CRASH [expected OK] /_mozilla/mozilla/iframe-contentDocument.html
CRASH [expected OK] /_webgl/conformance/glsl/misc/re-compile-re-link.html
OK /beacon/beacon-basic.https.window.html (#41723)
- FAIL [expected PASS] subtest: Payload size restriction should be accumulated: type = blob
```
assert_false: expected false got true
```
OK /cookies/partitioned-cookies/partitioned-cookies-samesite-attribute.https.html
- FAIL [expected PASS] subtest: In embedded cross-site contexts, partitioned cookies can only be set with explicit SameSite=None
```
assert_equals: expected 0 but got 3
```
FAIL [expected PASS] /css/css-backgrounds/background-size-042.html
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 2
OK /css/css-display/empty-text-baseline-001.html
- FAIL [expected PASS] subtest: Empty second line in #inner does not generate baseline for #span
```
assert_equals: expected 2 but got 0
```
- FAIL [expected PASS] subtest: Empty second line in #inner does not generate baseline for #span with white-space: pre-line
```
assert_equals: expected 2 but got 0
```
- FAIL [expected PASS] subtest: Empty second line in #inner does not generate baseline for #span with white-space: pre
```
assert_equals: expected 2 but got 0
```
FAIL [expected PASS] /css/css-ui/appearance-button-001.html
FAIL [expected PASS] /css/css-ui/appearance-checkbox-001.html
CRASH [expected OK] /fetch/api/headers/headers-structure.any.html
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/accumulated-oversized-payload.https.window.html (#41705)
ERROR [expected OK] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- FAIL [expected PASS] subtest: content sec-fetch-site - HTTPS downgrade-upgrade
```
assert_unreached: Reached unreachable code
```
ERROR [expected TIMEOUT] /html/browsers/browsing-the-web/history-traversal/pageswap/pageswap-initial-navigation.html (#40387)
OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit.html (#44028)
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html (#39694)
- PASS [expected FAIL] subtest: Meta refresh is blocked by the allow-scripts sandbox flag at its creation time, not when refresh comes due

OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-location-assign.html (#32863)

FAIL [expected PASS] subtest: Navigating iframe loading='lazy' before it is loaded: location.assign

uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?nav" but got "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src"

TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
- PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.
OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.worker-module.html (#43510)
- FAIL [expected PASS] subtest: Revoking a blob URL immediately after calling import will not fail
```
promise_test: Unhandled rejection with value: object "TypeError: Module fetching failed"
```
OK /html/webappapis/dynamic-markup-insertion/document-write/iframe_005.html (#43671)
- PASS [expected FAIL] subtest: document.write external script into iframe write back into parent
OK /html/webappapis/dynamic-markup-insertion/document-write/module-tla-import.html (#42419)
- FAIL [expected PASS] subtest: document.write in an imported module
```
assert_true: onload must be called expected true got false
```
TIMEOUT [expected OK] /infrastructure/testdriver/click_nested.html (#43887)
- NOTRUN [expected FAIL] subtest: TestDriver click method with multiple windows and nested iframe
PASS [expected FAIL] /png/apng/acTL-plays-one.html (#41218)
TIMEOUT [expected OK] /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html
- NOTRUN [expected PASS] subtest: touch two-finger pan on 'touch-action: pan-x pan-y'
- NOTRUN [expected FAIL] subtest: touch two-finger pan on 'touch-action: pinch-zoom'
OK /resource-timing/buffer-full-add-then-clear.html (#40819)
- PASS [expected FAIL] subtest: Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one
OK [expected CRASH] /resource-timing/render-blocking-status-link.html (#41664)
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- PASS [expected FAIL] subtest: Click event should be fired when touchend opens synchronous XHR
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- PASS [expected TIMEOUT] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK /webdriver/tests/classic/execute_script/promise.py (#44455)
- FAIL [expected PASS] subtest: test_promise_reject_timeout_none
```
AssertionError
```
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
OK /xhr/send-redirect.htm (#32026)
- FAIL [expected PASS] subtest: XMLHttpRequest: send() - Redirects (basics) (303, GET, content.py)
```
assert_equals: expected (string) "GET" but got (object) null
```

Stable unexpected results that are known to be intermittent (19)

TIMEOUT [expected OK] /_mozilla/mozilla/window-resize-event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- PASS [expected FAIL] subtest: WebGL test #45
- PASS [expected FAIL] subtest: WebGL test #47
- PASS [expected FAIL] subtest: WebGL test #49
- PASS [expected FAIL] subtest: WebGL test #51
- FAIL [expected PASS] subtest: WebGL test #53
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #55
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #57
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #59
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- PASS [expected FAIL] subtest: WebGL test #61
- PASS [expected FAIL] subtest: WebGL test #63
- And 14 more unexpected results...
OK /css/css-cascade/layer-cssom-order-reverse.html (#36094)
- PASS [expected FAIL] subtest: Delete layer invalidates @font-face
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(nastaliq)
```
assert_equals: quoted generic(nastaliq) matches  @font-face rule expected 50 but got 30
```
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted sans-serif (drawing text in a canvas)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted cursive (drawing text in a canvas)
```
assert_equals: quoted cursive matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
```
assert_equals: quoted fantasy matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted monospace (drawing text in a canvas)
```
assert_equals: quoted monospace matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted system-ui (drawing text in a canvas)
```
assert_equals: quoted system-ui matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted math (drawing text in a canvas)
```
assert_equals: quoted math matches  @font-face rule expected 125 but got 40
```
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai) (drawing text in a canvas)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted ui-serif (drawing text in a canvas)
```
assert_equals: quoted ui-serif matches  @font-face rule expected 125 but got 40
```
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-dest
- PASS [expected FAIL] subtest: sec-fetch-user
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- PASS [expected FAIL] subtest: Link with onclick navigation and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-204.html (#44521)
- PASS [expected FAIL] subtest: Navigating to a different document with link click
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- FAIL [expected PASS] subtest: load event does not fire on window.open('about:blank')
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace

OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-requestsubmit.html (#44098)

FAIL [expected TIMEOUT] subtest: Replace before load, triggered by formElement.requestSubmit()

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement=" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20form%20%3D%20document.createElement(%22form%22)%3B%0A%20%20%20%20form.action%20%3D%20%22%2Fcommon%2Fblank.html%22%3B%0A%0A%20%20%20%20const%20input%20%3D%20document.createElement(%22input%22)%3B%0A%20%20%20%20input.type%20%3D%20%22hidden%22%3B%0A%20%20%20%20input.name%20%3D%20%22thereplacement%22%3B%0A%20%20%20%20form.append(input)%3B%0A%0A%20%20%20%20document.currentScript.before(form)%3B%0A%20%20%20%20form.requestSubmit()%3B%0A%20%20"

ERROR [expected OK] /html/canvas/offscreen/text/2d.text.measure.getActualBoundingBox.tentative.html (#43710)
OK /html/semantics/embedded-content/media-elements/seeking/seek-to-max-value.htm (#40626)
- PASS [expected FAIL] subtest: seek to Number.MAX_VALUE
OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.worker.html (#33909)
- PASS [expected FAIL] subtest: Revoking a blob URL immediately after calling import will not fail
OK /mixed-content/tentative/autoupgrades/video-upgrade.https.sub.html (#41135)
- FAIL [expected PASS] subtest: Video autoupgraded
```
assert_equals: Length. expected 1 but got Infinity
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
```
assert_true: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
```
assert_true: Reload domContentLoadedEventStart &gt; Original domContentLoadedEventStart expected true got false
```
- FAIL [expected PASS] subtest: Reload domInteractive > Original domInteractive
```
assert_true: Reload domInteractive &gt; Original domInteractive expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```
OK /resource-timing/buffer-full-when-populate-entries.html (#44408)
- FAIL [expected PASS] subtest: Test that a buffer full event does not bubble and that resourcetimingbufferfull is called only once per overflow
```
assert_equals: onresourcetimingbufferfull should have been invoked once. expected 1 but got 0
```
OK /trusted-types/trusted-types-reporting.html (#43737)
- FAIL [expected PASS] subtest: Trusted Type violation report: creating a forbidden-but-not-reported policy.
```
assert_equals: a single violation reported expected 1 but got 0
```
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- FAIL [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
assert_true: about:blank window opened by 3P iframe does not inherit 3P iframe's StorageKey expected true got false
```

github-actions · 2026-04-28T12:59:32Z

✨ Try run (#25051844711) succeeded.

some more unrooting

9dc8642

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>

Narfinger requested a review from gterzian as a code owner April 27, 2026 13:20

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 27, 2026

Narfinger added 2 commits April 27, 2026 16:41

implement partialeq for unrooted

78bdfff

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>

fix clippy

72eee14

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>

fix partialeq

9d965e3

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>

jdm approved these changes Apr 28, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 28, 2026

jdm added this pull request to the merge queue Apr 28, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 28, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 28, 2026

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 28, 2026

Narfinger marked this pull request as draft April 28, 2026 11:03

Narfinger added the T-linux-wpt Do a try run of the WPT label Apr 28, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Apr 28, 2026

fix wrong index

f6f80b3

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>

jdm reviewed Apr 28, 2026

View reviewed changes

Comment thread components/script/dom/execcommand/commands/delete.rs Outdated

Narfinger added the T-linux-wpt Do a try run of the WPT label Apr 28, 2026

fix wrong index again

cc9f615

Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Apr 28, 2026

Narfinger marked this pull request as ready for review April 28, 2026 13:08

servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 28, 2026

jdm added this pull request to the merge queue Apr 28, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 28, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 28, 2026

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 28, 2026

jdm added this pull request to the merge queue Apr 28, 2026

servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 28, 2026

Merged via the queue into servo:main with commit 28de8ab Apr 28, 2026
77 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 28, 2026

Narfinger deleted the more-unrooting branch April 29, 2026 06:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

script: Replace some usage of children() with children_unrooted() in script/dom/execcommand#44544

script: Replace some usage of children() with children_unrooted() in script/dom/execcommand#44544
jdm merged 6 commits into
servo:mainfrom
Narfinger:more-unrooting

Narfinger commented Apr 27, 2026 •

edited

Loading

Uh oh!

Narfinger commented Apr 27, 2026

Uh oh!

jdm commented Apr 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Narfinger commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Narfinger commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Narfinger commented Apr 27, 2026

Uh oh!

jdm commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Narfinger commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Narfinger commented Apr 27, 2026 •

edited

Loading

jdm commented Apr 28, 2026 •

edited

Loading