servoshell (FreeBSD): Fix build failure and add CJK fonts for egui#44514
Merged
Conversation
Build on FreeBSD failed since no implementation of configure_fonts() in ports/servoshell/desktop/gui.rs was enabled. Add the font locations on FreeBSD to the Linux implementation, and allow using it also when target_os = "freebsd". Testing: Viewed the same test file as in 2124599 (servoshell (Linux): Add CJK fonts for egui (servo#44138), 2026-04-13) with servoshell on FreeBSD. Before: Servoshell fails to build After: Tab title displays correctly Signed-off-by: Juhani Krekelä <juhani@xn--krekel-gua.fi>
jdm
approved these changes
Apr 27, 2026
yezhizhen
approved these changes
Apr 27, 2026
Member
|
Didn't realise freebsd has a separate target_os env |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build on FreeBSD failed since no implementation of configure_fonts() in ports/servoshell/desktop/gui.rs was enabled.
Add the font locations on FreeBSD to the Linux implementation, and allow using it also when target_os = "freebsd".
Testing: Viewed the same test file as in 2124599 (servoshell (Linux): Add CJK fonts for egui (#44138), 2026-04-13) with servoshell on FreeBSD.
Before: Servoshell fails to build
After: Tab title displays correctly