script: move drop implementation to a separate struct from WebGLTexture (#26488)#44513
Merged
jdm merged 1 commit intoApr 28, 2026
Conversation
TimvdLippe
reviewed
Apr 26, 2026
0a8e02c to
1aa6c4d
Compare
…re (servo#26488) Move the drop logic for WebGLTexture into a new `DroppableWebGLTexture` struct, removing the `allowDropImpl` binding configuration. This also switches WebXR session and rendering context references to `WeakRef` to avoid cycles, and changes `detach_texture` to accept a `WebGLTextureId` directly instead of a `&WebGLTexture` reference. Fixes: Partially servo#26488 Signed-off-by: Domenico Rizzo <domenico.rizzo@gmail.com> Signed-off-by: Domenico Rizzo <domenico.rizzo@gmail.com> script: add `must_root` lint attribute to `DroppableWebGLTexture` Applies the `crown::unrooted_must_root_lint::must_root` annotation to `DroppableWebGLTexture` to enforce proper GC root safety for this DOM-adjacent type. Fixes: Partially servo#26488 Signed-off-by: Domenico Rizzo <domenico.rizzo@gmail.com> Signed-off-by: Domenico Rizzo <domenico.rizzo@gmail.com>
1aa6c4d to
b78dfb0
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the drop logic for WebGLTexture into a new
DroppableWebGLTexturestruct, removing theallowDropImplbinding configuration. This also switches WebXR session and rendering context references toWeakRefto avoid cycles, and changesdetach_textureto accept aWebGLTextureIddirectly instead of a&WebGLTexturereference.Testing: WebGLTests should cover the related parts.
Fixes: Partially #26488