layout: value of <input type=file> now inherits ‘color’ by default#44496
Merged
Conversation
Signed-off-by: Sabb <sarafaabbas@gmail.com>
|
🔨 Triggering try run (#25022792557) for Linux (WPT) |
Loirooriol
reviewed
Apr 27, 2026
| border: none; | ||
| background: transparent; | ||
| color: initial; | ||
| color: inherit; |
Contributor
There was a problem hiding this comment.
color inherits by default. Do you need to override some other declaration?
Contributor
Author
There was a problem hiding this comment.
It wasn't inheriting the colour until I changed the value.
I don't think there's need to override any other declarations.
Contributor
There was a problem hiding this comment.
If there is no other declaration to override, then it will inherit anyways, because color is an inherited property.
So if you needed inherit, I wonder if it would make more sense to restrict the selector that sets the other declaration.
Contributor
Author
There was a problem hiding this comment.
Yes, I just found this up at the beginning of the file;
input, textarea { background: white; border: solid grey 1px; color: black; }
Do you reckon I restrict it here?
|
Test results for linux-wpt from try job (#25022792557): Flaky unexpected result (43)
Stable unexpected results that are known to be intermittent (15)
|
|
✨ Try run (#25022792557) succeeded. |
Signed-off-by: Sabb <sarafaabbas@gmail.com>
Contributor
Author
|
@Loirooriol check it out now, tests still passing. |
Loirooriol
reviewed
Apr 29, 2026
Comment on lines
177
to
178
| border: none; | ||
| background: transparent; |
Contributor
There was a problem hiding this comment.
Are these still needed?
Contributor
Author
There was a problem hiding this comment.
Honestly not sure, I tend to only want to work on the task alone, don't fancy digging around other parts of the code to not break anything.
Do you think I'd remove it?
Contributor
There was a problem hiding this comment.
I was mentioning because with the :not([type="file"]), now background: white; border: solid grey 1px; is no longer applied.
Signed-off-by: Sabb <sarafaabbas@gmail.com>
Contributor
Author
|
@Loirooriol thanks for the heads up, I've pushed the changes |
Loirooriol
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made value of now inherit ‘color’ by default
Testing:
./mach test-wpt tests/wpt/mozilla/tests/css/input-file-color-inherit.htmlpasses successfully.Fixes: #44427