script: propagate &mut JSContext in DebuggerGlobalScope::fire_eval#44477
Merged
Gae24 merged 4 commits intoApr 24, 2026
Conversation
Signed-off-by: Emmanuel Paul Elom <elomemmanuel007@gmail.com>
Gae24
requested changes
Apr 24, 2026
…ported Co-authored-by: Gae24 <96017547+Gae24@users.noreply.github.com> Signed-off-by: elomscansio <163124154+elomscansio@users.noreply.github.com>
Co-authored-by: Gae24 <96017547+Gae24@users.noreply.github.com> Signed-off-by: elomscansio <163124154+elomscansio@users.noreply.github.com>
Gae24
requested changes
Apr 24, 2026
| let _realm = enter_realm(self); | ||
| let debuggee_pipeline_id = | ||
| crate::dom::pipelineid::PipelineId::new(self.upcast(), debuggee_pipeline_id, can_gc); | ||
| enter_auto_realm(cx, self); |
Contributor
There was a problem hiding this comment.
Actually you can do
let mut realm = enter_auto_realm(cx, self);
let cx = &mut realm;
The same for the other PR:
…time error Signed-off-by: Emmanuel Paul Elom <elomemmanuel007@gmail.com>
a8f1e47 to
522b844
Compare
Gae24
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate
&mut JSContextinDebuggerGlobalScope::fire_evalTesting: Successful build is enough
Fixes: Part of #42638
Opened to reduces the complexity of #44254