storage: Add support for temporary storage#44433
Conversation
|
🔨 Triggering try run (#24776187248) for Linux (WPT) |
|
|
Test results for linux-wpt from try job (#24776187248): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (22)
Stable unexpected results (9)
|
|
|
|
🔨 Triggering try run (#24777475237) for Linux (WPT) |
c853601 to
b610a65
Compare
|
Test results for linux-wpt from try job (#24777475237): Flaky unexpected result (35)
Stable unexpected results that are known to be intermittent (21)
Stable unexpected results (9)
|
|
🔨 Triggering try run (#24779723487) for Linux (WPT) |
|
|
|
Test results for linux-wpt from try job (#24779723487): Flaky unexpected result (33)
Stable unexpected results that are known to be intermittent (17)
|
|
✨ Try run (#24779723487) succeeded. |
|
🔨 Triggering try run (#24782673041) for Linux (Unit Tests, Build libservo, WPT, Bencher), Windows (Unit Tests, Build libservo), MacOS Arm64 (Unit Tests), Android, OpenHarmony, Lint |
|
| Branch | 44433/PR |
| Testbed | self-hosted-image:servo-ubuntu2204-bench |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
|
| Branch | 44433/PR |
| Testbed | HUAWEI Mate 60 Pro |
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
|
Test results for linux-wpt from try job (#24782673041): Flaky unexpected result (24)
Stable unexpected results that are known to be intermittent (19)
|
|
@jdm Do you think something like this would help for now? |
|
✨ Try run (#24782673041) succeeded. |
d53ebc1 to
1a37be6
Compare
jdm
left a comment
There was a problem hiding this comment.
I'm ok with this as a bandaid fix if we think that sharing storage across multiple servo processes in tests is causing issues. I think we should revert this change once we have a proper fix for using independent config directories per servo test process that is launched.
Add support for temporary storage via a new config option `temporary_storage` and a corresponding command-line argument `--temporary-storage`. When enabled, client storage uses a storage directory (e.g. `clientstorage/temporary/<uuid>`) instead of the shared default location. This can be used to provide isolation between concurrent servo instances. This is especially useful for WPT runs, where multiple Servo instances may execute in parallel and would otherwise share the same storage, leading to cross-test interference. Based on that, this patch also updates the WPT runner to enable temporary storage by default. Signed-off-by: Jan Varga <jvarga@igalia.com>
Right, I added a comment to |
Add support for temporary storage via a new config option
temporary_storageand a corresponding command-line argument
--temporary-storage.When enabled, client storage uses a storage directory
(e.g.
clientstorage/temporary/<uuid>) instead of the shared default location.This can be used to provide isolation between concurrent servo instances.
This is especially useful for WPT runs, where multiple Servo instances may
execute in parallel and would otherwise share the same storage, leading to
cross-test interference.
Based on that, this PR also updates the WPT runner to enable temporary storage
by default.
Testing: Manual testing and a full try run.