layout: Use a consistent definition of "document white space"#44424
Merged
mrobinson merged 1 commit intoApr 28, 2026
Merged
Conversation
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#59396) with upstreamable changes. |
Loirooriol
reviewed
Apr 22, 2026
| self.text | ||
| .bytes() | ||
| .all(|byte| matches!(byte, b' ' | b'\n' | b'\t')) | ||
| .all(|byte| InlineFormattingContextBuilder::is_document_white_space(byte.into())) |
Contributor
There was a problem hiding this comment.
I have tested Firefox and Chrome, and U+000C doesn't create a flex item:
<!DOCTYPE html>
<div style="display: flex; justify-content: space-between"><span>item</span></div>But it's not included in is_document_white_space
Member
Author
There was a problem hiding this comment.
I wasn't sure how to test this, so it is good to have confirmation. I've updated the change to include the form feed character (U+00C), which also happens to be WhatWG's definition of ASCII white space and the Rust is_ascii_whitespace function.
84880d4 to
2458b1f
Compare
|
🔨 Triggering try run (#24788358751) for Linux (WPT) |
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#59396). |
|
Test results for linux-wpt from try job (#24788358751): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (18)
|
|
✨ Try run (#24788358751) succeeded. |
2458b1f to
ab97e93
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#59396). |
mukilan
approved these changes
Apr 28, 2026
SimonSapin
approved these changes
Apr 28, 2026
Member
Author
|
Hrm. The DCO bot seems to be wedged. |
Member
Perhaps you can try doing a rebase + force push again. |
Because the definition of "document white space" differed in various places in Servo layout, it was possible for the flexbox container builder to expect to be able to build an inline formatting context from text that was ultimately determined to be empty by the inline formatting context builder. This led to a `BoxSlot` not being properly filled (a thing that should never happen) and an assertion failing. This change fixes that issue. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
ab97e93 to
2c780ba
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#59396). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the definition of "document white space" differed in various
places in Servo layout, it was possible for the flexbox container
builder to expect to be able to build an inline formatting context from
text that was ultimately determined to be empty by the inline formatting
context builder. This led to a
BoxSlotnot being properly filled (athing that should never happen) and an assertion failing.
This change fixes that issue.
Testing: This change adds a new WPT crash test.
Fixes: #43550.