net: Update test cookie expiration dates to one century in the future.#44341
Merged
Conversation
Signed-off-by: Josh Matthews <josh@joshmatthews.net>
mukilan
approved these changes
Apr 19, 2026
|
Not a serious problem, but the weekdays are wrong. For example, 18-Apr-2127 is a Friday, not Sunday. |
Member
Author
|
Yeah, I think the date parsing ignores the day name so it's not a concern. |
|
100 years from now someone will be equally annoyed that you didn't just set it to 3026. I hope that future coder reads this PR and only sets it 100 years into their future so that we can keep the chain of minor annoyances going. |
|
Why not mock the system time so that this is never an issue? Something like this: https://github.com/museun/mock_instant |
|
What if in 100 years, someone is still here to update it to 1000 years 🤣🤣 |
jschwe
pushed a commit
to jschwe/servo
that referenced
this pull request
Apr 27, 2026
servo#44341) These dates were chosen 10 years ago, which I'm sure felt like a reasonably far-future date for a very young web engine. Surprise! We're still here, so we can be more bold this time. Testing: Unit tests stop failing. Signed-off-by: Josh Matthews <josh@joshmatthews.net> (cherry picked from commit 19354a5)
jschwe
pushed a commit
to jschwe/servo
that referenced
this pull request
Apr 27, 2026
…the future. This backports servo#44341 to release/v0.1 to fix unit-test failures, due to hardcoded expiration date. ----------------------------------- These dates were chosen 10 years ago, which I'm sure felt like a reasonably far-future date for a very young web engine. Surprise! We're still here, so we can be more bold this time. Testing: Unit tests stop failing. Signed-off-by: Josh Matthews <josh@joshmatthews.net> (cherry picked from commit 19354a5)
jschwe
pushed a commit
that referenced
this pull request
Apr 28, 2026
…the future. This backports #44341 to release/v0.1 to fix unit-test failures, due to hardcoded expiration date. ----------------------------------- These dates were chosen 10 years ago, which I'm sure felt like a reasonably far-future date for a very young web engine. Surprise! We're still here, so we can be more bold this time. Testing: Unit tests stop failing. Signed-off-by: Josh Matthews <josh@joshmatthews.net> (cherry picked from commit 19354a5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These dates were chosen 10 years ago, which I'm sure felt like a reasonably far-future date for a very young web engine. Surprise! We're still here, so we can be more bold this time.
Testing: Unit tests stop failing.