Skip to content

Match on NonNull::new instead of using is_null() and expect()#44221

Merged
mukilan merged 1 commit into
servo:mainfrom
rovertrack:issue-44210
Apr 15, 2026
Merged

Match on NonNull::new instead of using is_null() and expect()#44221
mukilan merged 1 commit into
servo:mainfrom
rovertrack:issue-44210

Conversation

@rovertrack

@rovertrack rovertrack commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

The code was doing repetitive work by checking if compiled_script is null and then assigning and expecting the same, combined and replaced with condition based working
Testing: The flow remains the same no new tests needed
Fixes: #44210

@rovertrack rovertrack requested a review from gterzian as a code owner April 15, 2026 01:54
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 15, 2026
@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 15, 2026
@rovertrack
Match on NonNull::new instead of using is_null() and expect()
5b48bfc 
Signed-off-by: Rover track <rishan.pgowda@gmail.com>
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Apr 15, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 15, 2026
@mukilan mukilan added this pull request to the merge queue Apr 15, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 15, 2026
@rovertrack

rovertrack commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks @mukilan.
Can you also review this #44133
Thanks

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 15, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Apr 15, 2026
@mukilan mukilan added this pull request to the merge queue Apr 15, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Apr 15, 2026
Merged via the queue into servo:main with commit 134beac Apr 15, 2026
39 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mukilan mukilan mukilan approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Match on NonNull::new instead of using is_null() and expect()

4 participants

@rovertrack @mukilan @jdm @servo-highfive