script: Clean up prepare the script element related code and remove ModuleOwner#44179
Merged
Conversation
9984c47 to
4c85989
Compare
jdm
approved these changes
Apr 17, 2026
jdm
left a comment
Member
There was a problem hiding this comment.
This is great! I'm glad to see this moving closer to the way the specification is written.
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
4c85989 to
889355c
Compare
Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>
CYBAI
approved these changes
Apr 18, 2026
CYBAI
left a comment
Member
There was a problem hiding this comment.
Thanks for the great clean up! 😍 Using on_complete callback with globalscope looks much easier to understand now 🤯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the
ModuleOwnerlogic in favour of closures passed down by the script fetching initiator.When processing inline module scripts a task in now queued on the networking task source. Since
Rc<ModuleTree>is notSend, aresultfield is now introduced toHTMLScriptElement, which is initialized before queueing the task.This slightly improves
inline-async-inserted-execorder.html, which now fails at the fourth assertion instead of stopping at the second one (the inline module script with no dependencies still resolves after the one that has a parse error).Testing: Covered by existing tests.