Skip to content

devcontainer: Verify build on PRs.#44111

Merged
jschwe merged 4 commits into
servo:mainfrom
jschwe:devcontainer-ci
Apr 13, 2026
Merged

devcontainer: Verify build on PRs.#44111
jschwe merged 4 commits into
servo:mainfrom
jschwe:devcontainer-ci

Conversation

@jschwe

@jschwe jschwe commented Apr 11, 2026

Copy link
Copy Markdown
Member

This allows us to verify that the devcontainer builds, when a PR changes any of the affected files.

Testing: This is a CI change

jschwe added 2 commits April 11, 2026 11:00
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
@jschwe jschwe mentioned this pull request Apr 11, 2026
@jschwe jschwe marked this pull request as ready for review April 12, 2026 13:27
@jschwe jschwe requested a review from sagudev as a code owner April 12, 2026 13:27
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 12, 2026
- main
# Only rebuild if the Dockerfile or dependencies change.
paths:
paths: &container-paths

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pretty recent change, although sadly merge keys are not supported.

@sagudev sagudev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Comment thread .github/workflows/docker.yml Outdated
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 12, 2026
Co-authored-by: Sam <16504129+sagudev@users.noreply.github.com>
Signed-off-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 12, 2026
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
@jschwe jschwe enabled auto-merge April 13, 2026 05:46
@jschwe jschwe added this pull request to the merge queue Apr 13, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 13, 2026
Merged via the queue into servo:main with commit b5d454e Apr 13, 2026
32 checks passed
@jschwe jschwe deleted the devcontainer-ci branch April 13, 2026 06:54
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants