script: Implement preserving ranges for moves during commands by TimvdLippe · Pull Request #44041 · servo/servo

TimvdLippe · 2026-04-08T19:54:35Z

This ensures that the selection after the move is as expected.
It mostly fixes tests that had fully passing implementation, but
the after fontsize was incorrect, since the selection wasn't
properly updated.

Some new regressions were false positives.

Part of #25005

Testing: WPT

github-actions · 2026-04-08T19:54:54Z

🔨 Triggering try run (#24155502525) for Linux (WPT)

github-actions · 2026-04-08T20:22:55Z

Test results for linux-wpt from try job (#24155502525):

Flaky unexpected result (36)

OK /IndexedDB/idbdatabase_deleteObjectStore.any.html (#43823)
- PASS [expected FAIL] subtest: Deleted object store's name should be removed from database's list. Attempting to use a deleted IDBObjectStore should throw an InvalidStateError

OK /IndexedDB/idbtransaction-oncomplete.any.worker.html (#42804)

FAIL [expected PASS] subtest: IDBTransaction - complete event

assert_array_equals: lengths differ, expected array ["upgradeneeded", "complete", "success", "opencursor"] length 4, got ["upgradeneeded", "complete", "success"] length 3

OK /_mozilla/css/offset_properties_inline.html (#40543)

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

CRASH [expected OK] /content-security-policy/meta/sandbox-iframe.html (#43478)
FAIL [expected PASS] /css/css-backgrounds/background-size-042.html
TIMEOUT [expected PASS] /css/css-images/image-set/image-set-resolution-002.html
FAIL [expected PASS] /css/css-ui/appearance-searchfield-001.html
FAIL [expected PASS] /css/css-ui/compute-kind-widget-generated/kind-of-widget-fallback-radio-input-border-bottom-left-radius-001.html
FAIL [expected PASS] /css/css-ui/webkit-appearance-menulist-001.html
FAIL [expected PASS] /css/css-ui/webkit-appearance-searchfield-001.html
CRASH [expected OK] /fetch/api/cors/cors-cookies.any.html
CRASH [expected OK] /fetch/api/policies/referrer-no-referrer.html
ERROR [expected OK] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/sandboxed-iframe.https.window.html (#41704)
OK /fetch/metadata/window-open.https.sub.html (#40339)
- FAIL [expected PASS] subtest: Same-site window, forced, reloaded
```
The operation is insecure.
```
ERROR [expected OK] /focus/focus-event-after-switching-iframes.sub.html (#40368)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- FAIL [expected TIMEOUT] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
assert_array_equals: animationFrame lengths differ, expected array ["autofocus", "scroll", "animationFrame"] length 3, got ["animationFrame"] length 1
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1.html (#39694)
- FAIL [expected PASS] subtest: Meta refresh is blocked by the allow-scripts sandbox flag at its creation time, not when refresh comes due
```
uncaught exception: Error: assert_unreached: The iframe from which the meta came from must not refresh Reached unreachable code
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- FAIL [expected PASS] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
```
uncaught exception: Error: assert_unreached: The iframe into which the meta was moved must not refresh Reached unreachable code
```
TIMEOUT /html/semantics/embedded-content/media-elements/preserves-pitch.html (#40352)
- PASS [expected TIMEOUT] subtest: Speed-ups should not change the pitch when preservesPitch=true
- TIMEOUT [expected NOTRUN] subtest: Slow-downs should not change the pitch when preservesPitch=true
```
Test timed out
```
OK [expected TIMEOUT] /html/semantics/embedded-content/media-elements/src_object_blob.html (#40340)
- PASS [expected TIMEOUT] subtest: HTMLMediaElement.srcObject blob
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
CRASH [expected ERROR] /html/semantics/forms/the-select-element/customizable-select/select-appearance-button-after-span.html
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- PASS [expected FAIL] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
- PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
- PASS [expected FAIL] subtest: Reload domInteractive > Original domInteractive
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
- PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
- PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
OK /navigation-timing/test-timing-reload.html
- FAIL [expected PASS] subtest: domInteractive is different after the reload.
```
assert_not_equals: domInteractive is different after the reload. got disallowed value 3.85
```
TIMEOUT [expected OK] /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html
- NOTRUN [expected PASS] subtest: touch two-finger pan on 'touch-action: pan-x pan-y'
- NOTRUN [expected FAIL] subtest: touch two-finger pan on 'touch-action: pinch-zoom'
OK /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (link)
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- PASS [expected FAIL] subtest: Click event should be fired when touchend opens synchronous XHR
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```

OK /webdriver/tests/classic/back/user_prompts.py

FAIL [expected PASS] subtest: test_accept[alert]

AssertionError: assert 'about:blank' == 'https://web-platform.test:8443/webdriver/tests/support/inline.py?doc=%3C%21doctype+html%3E%0A%3Cmeta+charset%3DUTF-8%3E%0A%3Cp+id%3D1%3E&amp;mime=text%2Fhtml&amp;charset=UTF-8'

OK /webdriver/tests/classic/close_window/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
OK /webxr/xrSession_features_deviceSupport.https.html (#24357)
- FAIL [expected PASS] subtest: Immersive XRSession requests with no supported device should reject
```
assert_unreached: Should have rejected: undefined Reached unreachable code
```

Stable unexpected results that are known to be intermittent (19)

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
CRASH [expected ERROR] /_webgl/conformance2/misc/uninitialized-test-2.html (#41656)
OK /beacon/beacon-basic.https.window.html (#41723)
- PASS [expected FAIL] subtest: Payload size restriction should be accumulated: type = arraybuffer
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong)
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted sans-serif (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted cursive (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai) (drawing text in a canvas)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(khmer-mul) (drawing text in a canvas)
```
assert_equals: unquoted generic(khmer-mul) does not match @font-face rule expected 40 but got 125
```
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- FAIL [expected PASS] subtest: sec-fetch-user
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - Not sent to non-trustworthy same-origin destination
```
Test timed out
```

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted
```
assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
```
ERROR [expected OK] /html/canvas/offscreen/text/2d.text.measure.getActualBoundingBox.tentative.html (#43710)

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus

assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;input autofocus=""&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

promise_test: Unhandled rejection with value: object "TypeError: can't access property "appendChild", w.document.querySelector(...) is null"

OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.html (#33948)
- FAIL [expected PASS] subtest: Revoking a blob URL immediately after calling import will not fail
```
promise_test: Unhandled rejection with value: object "TypeError: Module fetching failed"
```
TIMEOUT [expected OK] /infrastructure/testdriver/click_nested.html (#43887)
- NOTRUN [expected FAIL] subtest: TestDriver click method with multiple windows and nested iframe
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK /resource-timing/test_resource_timing.html (#25720)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (xmlhttprequest)
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- TIMEOUT [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
TIMEOUT /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- TIMEOUT [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.

Stable unexpected results (2)

OK /editing/run/forwarddelete.html?6001-7000
- PASS [expected FAIL] subtest: [["styleWithCSS","false"],["defaultparagraphseparator","div"],["forwarddelete",""]] "foo[]bar" queryCommandValue("fontSize") before
- PASS [expected FAIL] subtest: [["styleWithCSS","false"],["defaultparagraphseparator","div"],["forwarddelete",""]] "foo[]bar" queryCommandValue("fontSize") after
OK /editing/run/forwarddelete.html?7001-last
- PASS [expected FAIL] subtest: [["styleWithCSS","false"],["defaultparagraphseparator","p"],["forwarddelete",""]] "foo[]bar" queryCommandValue("fontSize") before
- PASS [expected FAIL] subtest: [["styleWithCSS","false"],["defaultparagraphseparator","p"],["forwarddelete",""]] "foo[]bar" queryCommandValue("fontSize") after
- PASS [expected FAIL] subtest: [["styleWithCSS","false"],["defaultparagraphseparator","div"],["forwarddelete",""]] "foo[]bar" queryCommandValue("fontSize") before
- PASS [expected FAIL] subtest: [["styleWithCSS","false"],["defaultparagraphseparator","div"],["forwarddelete",""]] "foo[]bar" queryCommandValue("fontSize") after
- PASS [expected FAIL] subtest: [["styleWithCSS","false"],["defaultparagraphseparator","p"],["forwarddelete",""]] "foo[]bar" queryCommandValue("fontSize") before
- PASS [expected FAIL] subtest: [["styleWithCSS","false"],["defaultparagraphseparator","p"],["forwarddelete",""]] "foo[]bar" queryCommandValue("fontSize") after
- PASS [expected FAIL] subtest: [["styleWithCSS","false"],["defaultparagraphseparator","div"],["forwarddelete",""]] "foo[]bar" queryCommandValue("fontSize") before
- PASS [expected FAIL] subtest: [["styleWithCSS","false"],["defaultparagraphseparator","div"],["forwarddelete",""]] "foo[]bar" queryCommandValue("fontSize") after
- PASS [expected FAIL] subtest: [["styleWithCSS","false"],["defaultparagraphseparator","p"],["forwarddelete",""]] "foo[]bar" queryCommandValue("fontSize") before
- PASS [expected FAIL] subtest: [["styleWithCSS","false"],["defaultparagraphseparator","p"],["forwarddelete",""]] "foo[]bar" queryCommandValue("fontSize") after

github-actions · 2026-04-08T20:23:04Z

⚠️ Try run (#24155502525) failed!

This ensures that the selection after the move is as expected. It mostly fixes tests that had fully passing implementation, but the after fontsize was incorrect, since the selection wasn't properly updated. Some new regressions were false positives. Part of servo#25005 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>

Signed-off-by: Tim van der Lippe <TimvdLippe@users.noreply.github.com>

sebsebmc · 2026-04-09T16:03:22Z

I'll take a look this evening if no one else picks it up before then

TimvdLippe added the T-linux-wpt Do a try run of the WPT label Apr 8, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Apr 8, 2026

TimvdLippe force-pushed the move-preserving-ranges branch from f348f5f to c4873db Compare April 9, 2026 07:22

TimvdLippe marked this pull request as ready for review April 9, 2026 07:22

TimvdLippe requested a review from gterzian as a code owner April 9, 2026 07:22

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 9, 2026

Update contenteditable.rs

36c041b

Signed-off-by: Tim van der Lippe <TimvdLippe@users.noreply.github.com>

sebsebmc self-assigned this Apr 9, 2026

sebsebmc approved these changes Apr 10, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 10, 2026

TimvdLippe added this pull request to the merge queue Apr 10, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 10, 2026

Merged via the queue into servo:main with commit 4b02f87 Apr 10, 2026
30 checks passed

TimvdLippe deleted the move-preserving-ranges branch April 10, 2026 05:12

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

script: Implement preserving ranges for moves during commands#44041

script: Implement preserving ranges for moves during commands#44041
TimvdLippe merged 2 commits into
servo:mainfrom
TimvdLippe:move-preserving-ranges

TimvdLippe commented Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

sebsebmc commented Apr 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

TimvdLippe commented Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

sebsebmc commented Apr 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants