Skip to content

script: Claim blob before loading <video> poster frame#44035

Merged
simonwuelker merged 2 commits into
servo:mainfrom
simonwuelker:video-frame-blob-claim
Apr 8, 2026
Merged

script: Claim blob before loading <video> poster frame#44035
simonwuelker merged 2 commits into
servo:mainfrom
simonwuelker:video-frame-blob-claim

Conversation

@simonwuelker

Copy link
Copy Markdown
Member

Refer to #43746 for a description of the problem. This change ensures that video posters can be loaded from blob URLs, even if the URL is revoked right after.

Testing: This change adds a test

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@simonwuelker simonwuelker requested a review from gterzian as a code owner April 8, 2026 15:57
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 8, 2026
Comment on lines +1 to +10
<!DOCTYPE html>
<html class="reftest-wait">
<head>
<title>Verifies that video poster is shown even if video element has 'preload="auto"' attribute</title>
<link rel="author" title="Simon Wülker" href="simon.wuelker@arcor.de">
<link rel="match" href="video-poster-shown-preload-auto-ref.html">
</head>
<body>
<video id="target" src="/media/video.webm" width="100" height="100"></video>
<script>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test passed before too, but depended on the timing of the fetch thread. Loading a blob is usually pretty fast, but I added a call to std::thread::sleep inside fetch and that makes the test fail before this fix.

@servo-wpt-sync

Copy link
Copy Markdown
Collaborator

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#59049) with upstreamable changes.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 8, 2026
@simonwuelker simonwuelker added this pull request to the merge queue Apr 8, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 8, 2026
Merged via the queue into servo:main with commit 695b8ee Apr 8, 2026
33 checks passed
@simonwuelker simonwuelker deleted the video-frame-blob-claim branch April 8, 2026 17:37
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 8, 2026
@servo-wpt-sync

Copy link
Copy Markdown
Collaborator

⛔ Failed to properly merge the upstream pull request (web-platform-tests/wpt#59049). Please address any CI issues and try to merge manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants