Skip to content

devtools: Make isAsync and isGenerator optional#44023

Merged
eerii merged 2 commits into
servo:mainfrom
atbrakhi:make-function-args-optional
Apr 9, 2026
Merged

devtools: Make isAsync and isGenerator optional#44023
eerii merged 2 commits into
servo:mainfrom
atbrakhi:make-function-args-optional

Conversation

@atbrakhi

@atbrakhi atbrakhi commented Apr 8, 2026

Copy link
Copy Markdown
Member

Make isAsync and isGenerator optional

Testing: Current tests as passing
Fixes: part of #36027

Co-authored-by: eri <eri@igalia.com>
Signed-off-by: atbrakhi <atbrakhi@igalia.com>
@atbrakhi atbrakhi requested a review from eerii as a code owner April 8, 2026 10:31
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 8, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 8, 2026
@eerii

eerii commented Apr 8, 2026

Copy link
Copy Markdown
Member

Let's wait for #44024 to be merged :)

Signed-off-by: eri <eri@igalia.com>
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 9, 2026
@eerii eerii enabled auto-merge April 9, 2026 11:41
@eerii eerii added this pull request to the merge queue Apr 9, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 9, 2026
Merged via the queue into servo:main with commit f32cc3d Apr 9, 2026
32 of 33 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 9, 2026
elomscansio added a commit to elomscansio/servo that referenced this pull request Apr 9, 2026
…nux-unit-tests)

{"fail_fast": false, "matrix": [{"name": "Linux (Unit Tests)", "workflow": "linux", "wpt": false, "profile": "release", "unit_tests": true, "build_libservo": false, "bencher": false, "coverage": false, "build_args": "", "wpt_args": "", "number_of_wpt_chunks": 20}]}
@eerii eerii mentioned this pull request Apr 16, 2026
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants