script: Pass &mut JSContext to Clipboard API's#43975
Merged
Merged
Conversation
sagudev
reviewed
Apr 6, 2026
Comment on lines
+99
to
+100
| let global = self.global(); | ||
| let global = GlobalScope::from_current_realm(realm); |
Member
There was a problem hiding this comment.
Our global story is interesting: #35434. I think generally one should use
in such cases (both code will have the same effect here).
Contributor
Author
There was a problem hiding this comment.
Reverted back to the original, since I didn't have an InRealm here yet.
Part of servo#40600 Follow-up to servo#43943 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
sagudev
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #40600
Follow-up to #43943
Testing: It compiles