Skip to content

devtools: Replace new with register for LayoutInspectorActor#43954

Merged
eerii merged 1 commit into
servo:mainfrom
sabbCodes:issue-43800-layout-inspector-actor
Apr 6, 2026
Merged

devtools: Replace new with register for LayoutInspectorActor#43954
eerii merged 1 commit into
servo:mainfrom
sabbCodes:issue-43800-layout-inspector-actor

Conversation

@sabbCodes

Copy link
Copy Markdown
Contributor

Replaced new with register for LayoutInspectorActor in walker.rs & layout.rs

Testing: No testing required, compiles successfully.
Fixes: Part of #43800

@sabbCodes sabbCodes requested review from atbrakhi and eerii as code owners April 5, 2026 23:22
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 5, 2026
Comment thread components/devtools/actors/inspector/walker.rs Outdated
@servo-highfive servo-highfive added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 6, 2026
Signed-off-by: Sabb <sarafaabbas@gmail.com>
@sabbCodes sabbCodes force-pushed the issue-43800-layout-inspector-actor branch from 6da0a8e to 57673b9 Compare April 6, 2026 07:33
@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Apr 6, 2026

@eerii eerii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 6, 2026
@eerii eerii added this pull request to the merge queue Apr 6, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 6, 2026
Merged via the queue into servo:main with commit 00aa8c0 Apr 6, 2026
33 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants