fonts: Clean up application of `word-spacing` by mrobinson · Pull Request #43899 · servo/servo

mrobinson · 2026-04-03T12:09:20Z

Let word_spacing be optional in ShapingOptions like
letter_spacing. In addition, send None for Canvas rendering instead
of the width of the space character. It is supposed to represent extra
space added between words. Finally, remove duplicated code that applied
word and letter spacing for the fast shaper. This can just reuse the
code from the Harfbuzz shaper.

Testing: This causes some canvas tests to start passing.

Let `word_spacing` be optional in `ShapingOptions` like `letter_spacing`. In addition, send `None` for Canvas rendering instead of the width of the space character. It is supposed to represent *extra* space added between words. Finally, remove duplicated code that applied word and letter spacing for the fast shaper. This can just reuse the code from the Harfbuzz shaper. Signed-off-by: Martin Robinson <mrobinson@igalia.com>

github-actions · 2026-04-03T12:12:11Z

🔨 Triggering try run (#23945703903) for Linux (WPT)

github-actions · 2026-04-03T13:16:20Z

Test results for linux-wpt from try job (#23945703903):

Flaky unexpected result (37)

OK /IndexedDB/idbdatabase_deleteObjectStore.any.html (#43823)
- PASS [expected FAIL] subtest: Deleted object store's name should be removed from database's list. Attempting to use a deleted IDBObjectStore should throw an InvalidStateError

OK /_mozilla/css/offset_properties_inline.html (#40543)

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

CRASH [expected OK] /_mozilla/mozilla/img_load_more_than_cache.html
CRASH [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- PASS [expected FAIL] subtest: WebGL test #93
- PASS [expected FAIL] subtest: WebGL test #95
- PASS [expected FAIL] subtest: WebGL test #97
- PASS [expected FAIL] subtest: WebGL test #99

ERROR [expected CRASH] /_webgl/conformance2/textures/misc/tex-3d-size-limit.html (#42881)

PASS [expected FAIL] subtest: WebGL test #1

FAIL [expected PASS] subtest: WebGL test #3

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #4

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #5

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #6

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #7

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #8

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #9

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #10

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #11

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

And 27 more unexpected results...

TIMEOUT [expected OK] /content-security-policy/inheritance/document-write-iframe.html (#41195)
- TIMEOUT [expected PASS] subtest: document.open() keeps inherited CSPs on transient about:blank.
```
Test timed out
```
CRASH [expected OK] /content-security-policy/meta/sandbox-iframe.html (#43478)
TIMEOUT [expected FAIL] /css/CSS2/generated-content/content-counter-015.xht
FAIL [expected PASS] /css/css-backgrounds/background-size-041.html
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- PASS [expected FAIL] subtest: Matching font-style: 'oblique 10deg' should prefer 'oblique -40deg -30deg' over 'italic'
FAIL [expected PASS] /css/css-ui/appearance-checkbox-001.html
PASS [expected FAIL] /css/css-ui/appearance-menulist-button-002.tentative.html
OK /fetch/content-length/api-and-duplicate-headers.any.html (#35873)
- FAIL [expected PASS] subtest: fetch() and duplicate Content-Length/Content-Type headers
```
promise_test: Unhandled rejection with value: object "TypeError: Network error: HTTP failure: client error (SendRequest)"
```
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- PASS [expected FAIL] subtest: sec-fetch-site - Same origin, no options - registration
ERROR [expected OK] /fetch/metadata/window-open.https.sub.html (#40339)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- FAIL [expected PASS] subtest: load event does not fire on window.open('about:blank')
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

CRASH [expected OK] /html/browsers/history/the-location-interface/replace-with-nested-iframe.html

OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)

FAIL [expected PASS] subtest: opener of discarded auxiliary browsing context

assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"

CRASH [expected OK] /html/canvas/element/canvas-host/2d.canvas.host.size.attributes.setAttribute.whitespace.html
ERROR [expected OK] /html/canvas/offscreen/text/2d.text.measure.getActualBoundingBox.tentative.html (#43710)
OK /html/semantics/embedded-content/media-elements/audio_loop_seek_to_eos.html (#41226)
- FAIL [expected PASS] subtest: seeking to the end of looping audio
```
promise_test: Unhandled rejection with value: object "TypeError: this argument is not a finite floating-point value"
```
OK /html/semantics/embedded-content/media-elements/playing-the-media-resource/loop-from-ended.tentative.html (#33778)
- FAIL [expected PASS] subtest: play() with loop set to true after playback ended
```
this argument is not a finite floating-point value
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
- PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.
OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.html (#33948)
- FAIL [expected PASS] subtest: Revoking a blob URL immediately after calling import will not fail
```
promise_test: Unhandled rejection with value: object "TypeError: Module fetching failed"
```
CRASH [expected OK] /imagebitmap-renderingcontext/context-creation.html
OK /infrastructure/testdriver/click_iframe.html
- FAIL [expected PASS] subtest: TestDriver click on a document in an iframe
```
Unhandled rejection: assert_unreached: click failed Reached unreachable code
```
OK /mixed-content/tentative/autoupgrades/video-upgrade.https.sub.html (#41135)
- FAIL [expected PASS] subtest: Video autoupgraded
```
assert_equals: Length. expected 1 but got Infinity
```
TIMEOUT [expected OK] /preload/modulepreload-sri.html (#43354)
- TIMEOUT [expected PASS] subtest: Script should not be loaded if modulepreload's integrity is invalid
```
Test timed out
```
OK /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (xmlhttprequest)
TIMEOUT /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- PASS [expected TIMEOUT] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- TIMEOUT [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
```
Test timed out
```
CRASH [expected OK] /webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/closed-audiocontext-construction.html

Stable unexpected results that are known to be intermittent (15)

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /beacon/beacon-basic.https.window.html (#41723)
- FAIL [expected PASS] subtest: Payload size restriction should be accumulated: type = blob
```
assert_false: expected false got true
```
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong) (drawing text in a canvas)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(kai) (drawing text in a canvas)
```
assert_equals: quoted generic(kai) matches  @font-face rule expected 125 but got 40
```
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-monospace (drawing text in a canvas)
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/sandboxed-iframe.https.window.html (#41704)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-mode
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- PASS [expected TIMEOUT] subtest: Non-HTMLElement should not support autofocus
- TIMEOUT [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
Test timed out
```
TIMEOUT /html/semantics/embedded-content/media-elements/preserves-pitch.html (#40352)
- PASS [expected TIMEOUT] subtest: Speed-ups should not change the pitch when preservesPitch=true
- TIMEOUT [expected NOTRUN] subtest: Slow-downs should not change the pitch when preservesPitch=true
```
Test timed out
```
OK [expected TIMEOUT] /infrastructure/testdriver/click_nested.html (#43887)
- FAIL [expected NOTRUN] subtest: TestDriver click method with multiple windows and nested iframe
```
can't access property "document", child.frames[2] is undefined
```
OK /mixed-content/tentative/autoupgrades/mixed-content-cors.https.sub.html (#41123)
- PASS [expected FAIL] subtest: Cross-Origin video should get upgraded even if CORS is set
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
- FAIL [expected PASS] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
```
assert_true: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
```
assert_true: Reload domContentLoadedEventStart &gt; Original domContentLoadedEventStart expected true got false
```
- PASS [expected FAIL] subtest: Reload domInteractive > Original domInteractive
- PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
- PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
- PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
OK [expected CRASH] /resource-timing/render-blocking-status-link.html (#41664)
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- FAIL [expected PASS] subtest: Click event should be fired when touchend opens synchronous XHR
```
assert_equals: expected "touchend@div, mousedown@div, mouseup@div, click@div" but got "touchend@div"
```
TIMEOUT /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- TIMEOUT [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.

github-actions · 2026-04-03T13:16:41Z

✨ Try run (#23945703903) succeeded.

janvarga

Not my main area, but this looks straightforward.

Loirooriol · 2026-04-08T16:30:28Z

Let word_spacing be optional in ShapingOptions like letter_spacing

I don't get why any of these should be optional at all. None is just equal to zero?

It's also inconsistent that segment_and_shape() turns zero into None for letter-spacing, but not for word-spacing.

mrobinson requested review from Loirooriol, gterzian and nicoburns as code owners April 3, 2026 12:09

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 3, 2026

mrobinson added the T-linux-wpt Do a try run of the WPT label Apr 3, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Apr 3, 2026

janvarga approved these changes Apr 6, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 6, 2026

mrobinson added this pull request to the merge queue Apr 6, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 6, 2026

Merged via the queue into servo:main with commit 82c2f14 Apr 6, 2026
71 checks passed

mrobinson deleted the allow-word-spacing-to-be-optional branch April 6, 2026 10:49

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 6, 2026

Loirooriol reviewed Apr 6, 2026

View reviewed changes

Comment thread components/layout/flow/inline/text_run.rs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fonts: Clean up application of `word-spacing`#43899

fonts: Clean up application of `word-spacing`#43899
mrobinson merged 1 commit into
servo:mainfrom
mrobinson:allow-word-spacing-to-be-optional

mrobinson commented Apr 3, 2026

Uh oh!

github-actions Bot commented Apr 3, 2026

Uh oh!

github-actions Bot commented Apr 3, 2026

Uh oh!

github-actions Bot commented Apr 3, 2026

Uh oh!

janvarga left a comment

Uh oh!

Uh oh!

Uh oh!

Loirooriol commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mrobinson commented Apr 3, 2026

Uh oh!

github-actions Bot commented Apr 3, 2026

Uh oh!

github-actions Bot commented Apr 3, 2026

Uh oh!

github-actions Bot commented Apr 3, 2026

Uh oh!

janvarga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Loirooriol commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants