script: Support sprintf-style substitutions in console methods#43897
Merged
Conversation
Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>
|
🔨 Triggering try run (#23944429964) for Linux (WPT) |
|
Test results for linux-wpt from try job (#23944429964): Flaky unexpected result (26)
Stable unexpected results that are known to be intermittent (17)
|
|
✨ Try run (#23944429964) succeeded. |
simonwuelker
reviewed
Apr 3, 2026
| Some('c') => { | ||
| chars.next(); | ||
| if arg_index < messages.len() { | ||
| arg_index += 1; // consume but ignore CSS styling |
Member
There was a problem hiding this comment.
"css styling"? Why can we ignore the argument in this case?
Contributor
Author
There was a problem hiding this comment.
"css styling"? Why can we ignore the argument in this case?
In https://console.spec.whatwg.org/#formatter, the behaviour is not yet specified but the argument is used for styling console output in other browers and I don't think Servo supports styled console output at the moment.
Member
There was a problem hiding this comment.
Thanks, I had naively assumed that %c would format a char like it does in C (:
simonwuelker
reviewed
Apr 4, 2026
simonwuelker
left a comment
Member
There was a problem hiding this comment.
LGTM, can you write a test?
You can test console functionality with the devtools tests in devtools_tests.py, there are already some other console tests that you can use as a reference.
simonwuelker
reviewed
Apr 4, 2026
| Some('d') | Some('i') => { | ||
| let spec = chars.next().unwrap(); | ||
| if arg_index < messages.len() { | ||
| let num = unsafe { ToNumber(*cx, messages[arg_index]) }; |
Member
There was a problem hiding this comment.
Does this throw if the value is a BigInt/Symbol like https://tc39.es/ecma262/#sec-tonumber? If so we need some if checks to avoid that.
Contributor
Author
I see, I'll give it a try |
…ormatter Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>
simonwuelker
reviewed
Apr 5, 2026
Comment on lines
+520
to
+522
| if num.is_err() { | ||
| unsafe { jsapi::JS_ClearPendingException(*cx) }; | ||
| } |
Member
There was a problem hiding this comment.
Rather than clearing the exception I'd prefer if we didn't call ToNumber at all in those error cases.
Member
There was a problem hiding this comment.
Well, gecko has https://searchfox.org/firefox-main/rev/0989a082704f0bda8d370ccd57402645d834757e/dom/console/Console.cpp#1332 too so I guess it's fine.
Contributor
Author
|
@simonwuelker is this good enough to land? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the Console Formatter operation for all console methods.
Fixes: #43827