script: Fully implement DocumentOrShadowRoot#activeElement#43861
Merged
Conversation
TimvdLippe
approved these changes
Apr 2, 2026
|
|
||
| impl Node { | ||
| /// <https://dom.spec.whatwg.org/#concept-tree-root> | ||
| pub(crate) fn root(&self) -> DomRoot<Node> { |
Contributor
There was a problem hiding this comment.
I am surprised we didn't have this before, but I don't remember what the method was. Also can't find it right now...
Member
Author
There was a problem hiding this comment.
There is also an Element::root_element(), but this returns the "document element" for the light tree, which isn't really in the specification and isn't what we need here.
Member
Author
There was a problem hiding this comment.
I'll use Node::GetRootNode as suggested by @simonwuelker below.
Contributor
There was a problem hiding this comment.
Aah yes that's the one! Maybe add a link to the spec to that method so that we can find it.
simonwuelker
reviewed
Apr 2, 2026
Comment on lines
+270
to
+280
| /// <https://dom.spec.whatwg.org/#concept-tree-root> | ||
| pub(crate) fn root(&self) -> DomRoot<Node> { | ||
| if self.is_in_a_document_tree() { | ||
| DomRoot::upcast(self.owner_document()) | ||
| } else { | ||
| self.inclusive_ancestors(ShadowIncluding::No) | ||
| .filter_map(DomRoot::downcast) | ||
| .last() | ||
| .expect("We know inclusive_ancestors will return `self` which is an element") | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Node::GetRootNode(Default::default()) does the same, and its a bit more optimized, so please use that instead.
c706724 to
c06ef50
Compare
simonwuelker
approved these changes
Apr 2, 2026
TimvdLippe
approved these changes
Apr 2, 2026
| if let Some(candidate) = DomRoot::downcast::<Element>(candidate.clone()) { | ||
| return Some(candidate); | ||
| } | ||
| assert_eq!(&*candidate, document.upcast::<Node>()); |
Contributor
There was a problem hiding this comment.
Suggested change
| assert_eq!(&*candidate, document.upcast::<Node>()); | |
| assert!(candidate.is::<Document>()); |
`DocumentOrShadowRoot#activeElement` should return retarged results. What that means is that if the DOM anchor of the `Document`'s focused focusable area is within a shadow root, `Document#activeElement` should return the shadow host. This change implements that behavior, properly returning the `activeElement` from both `Document` and `ShadowRoot`. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
c06ef50 to
be1ddca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocumentOrShadowRoot#activeElementshould return retargeted results.What that means is that if the DOM anchor of the
Document's focusedfocusable area is within a shadow root,
Document#activeElementshouldreturn the shadow host. This change implements that behavior, properly
returning the
activeElementfrom bothDocumentandShadowRoot.Testing: This causes a decent number of WPT tests and subtests to start
passing. One subtest starts to fail, because it uses the
autofocusattributewhich we do not yet support.