script: Remove useless upcast::<Element> calls#43824
Merged
Merged
Conversation
Signed-off-by: webbeef <me@webbeef.org>
yezhizhen
approved these changes
Apr 1, 2026
Comment on lines
1418
to
+1419
| fn as_element(&self) -> &Element { | ||
| self.upcast::<Element>() | ||
| &self.element |
Member
There was a problem hiding this comment.
I love this change in particular :)
Contributor
|
Trying to get more context here. |
Member
Probably a typo. I think @webbeef mean "not costly" based on context? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upcast::() is costly in general, but in some cases we can avoid that call and use a direct field access instead.
Testing: no test change expected.