Skip to content

devtools: Rename CssPropertiesActor variable names#43745

Merged
eerii merged 1 commit into
servo:mainfrom
sabbCodes:issue-43606-css-properties-actor
Mar 30, 2026
Merged

devtools: Rename CssPropertiesActor variable names#43745
eerii merged 1 commit into
servo:mainfrom
sabbCodes:issue-43606-css-properties-actor

Conversation

@sabbCodes

Copy link
Copy Markdown
Contributor

Renamed CssPropertiesActor variable names in browsing_context

Testing: No testing required.
Fixes: Part of #43606

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 29, 2026

@eerii eerii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Mar 29, 2026
@eerii eerii added this pull request to the merge queue Mar 29, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 29, 2026
@eerii eerii removed this pull request from the merge queue due to a manual request Mar 29, 2026
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 29, 2026
@eerii

eerii commented Mar 29, 2026

Copy link
Copy Markdown
Member

It seems this one will have conflicts with another one in the merge queue, let's wait until that's merged, sorry!

Signed-off-by: Sabb <sarafaabbas@gmail.com>
@sabbCodes sabbCodes force-pushed the issue-43606-css-properties-actor branch from 908eb7c to e873acf Compare March 29, 2026 15:47
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 29, 2026
@sabbCodes

Copy link
Copy Markdown
Contributor Author

Hi @eerii, I've resolved the possible conflicts as the other one has been merged

@eerii eerii added this pull request to the merge queue Mar 30, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 30, 2026
Merged via the queue into servo:main with commit 40fc2b8 Mar 30, 2026
33 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants